From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LqN0s-0008MY-4y for garchives@archives.gentoo.org; Sun, 05 Apr 2009 07:43:30 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 81556E04DA; Sun, 5 Apr 2009 07:43:28 +0000 (UTC) Received: from amun.cheops.ods.org (amun.cheops.ods.org [82.95.138.191]) by pigeon.gentoo.org (Postfix) with ESMTP id 50303E04DA for ; Sun, 5 Apr 2009 07:43:28 +0000 (UTC) Received: from tefnut.cheops.ods.org ([2001:888:1022:0:211:24ff:fe37:e46e] helo=gentoo.org) by amun.cheops.ods.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1LqN0o-0004T9-Mz for gentoo-dev@lists.gentoo.org; Sun, 05 Apr 2009 09:43:27 +0200 Date: Sun, 5 Apr 2009 09:43:10 +0200 From: Fabian Groffen To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: flag-o-matic.eclass Message-ID: <20090405074310.GA9693@gentoo.org> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20090404184950.08b6cfc8@halo.dirtyepic.sk.ca> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20090404184950.08b6cfc8@halo.dirtyepic.sk.ca> User-Agent: Mutt/1.5.19 (Darwin 8.11.0, VIM - Vi IMproved 7.2) Organization: Gentoo Foundation, Inc. X-Content-Scanned: by amun.cheops.ods.org (Exim Exiscan) using SpamAssassin and ClamAV X-Archives-Salt: 1f617fed-e860-4e85-9a37-362598718b0e X-Archives-Hash: 2e8cca1f6db0740d30dc7415ceeea01e On 04-04-2009 18:49:50 -0600, Ryan Hill wrote: > > + # killing these two on OSX/Intel will disable SSE, resulting in failing > > + # compilations, as the headers expect SSE to be enabled (Apple knows what > > + # hardware they run on afterall, don't they?) > > + [[ ${CHOST} == i?86-apple-darwin* ]] \ > > + && ALLOWED_FLAGS="${ALLOWED_FLAGS} -march=prescott -march=nocona" > > > > Why do these have to be specifically included? Aren't they handed by > > 34 export ALLOWED_FLAGS="${ALLOWED_FLAGS} -O -O0 -O1 -O2 -mcpu -march -mtune" Looking at the current code, it can't even work properly. Even in the case when ALLOWED_FLAGS is already set. if [[ -z ${ALLOWED_FLAGS} ]] ; then export ALLOWED_FLAGS="-pipe" export ALLOWED_FLAGS="${ALLOWED_FLAGS} -O -O0 -O1 -O2 -mcpu -march" Weird enough, it /did/ enable compilations to succeed in the past, but it just can't in the current eclass, so it's bogus, and I will remove it again. Thanks for the check, much appreciated! -- Fabian Groffen Gentoo on a different level