Re: [gentoo-dev] Re: perl-module.eclass -- review - 2

[Donnie Berkholz <dberkholz@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On 12:28 Sat 28 Feb     , Torsten Veller wrote:
> case "${EAPI:-0}" in
> 	0|1)
> 		EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst pkg_prerm pkg_postrm src_compile src_install src_test src_unpack
> 		;;
> 	*)
> 		EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_test src_install
> 		;;
> esac

Maybe this is just me, but I prefer to reserve '*' cases for the 
fallback when I don't understand what I'm given.

> 	find "${D}/${VENDOR_LIB}" -type f -a \( -name .packlist \
> 		-o \( -name '*.bs' -a -empty \) \) -delete
> 	find "${D}/${VENDOR_LIB}" -depth -mindepth 1 -type d -empty -delete

I'm curious how portable the find () construct is. Do you know?

> 	find "${D}" -type f -not -name '*.so' | while read f ; do
> 		if file "${f}" | grep -q -i " text" ; then
> if grep -q "${D}" "${f}" ; then ewarn "QA: File contains a temporary path ${f}" ; fi
> 			sed -i -e "s:${D}:/:g" "${f}" || die

Could you just use dosed here?

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]