public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Timothy Redaelli <drizzt@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Mike Frysinger <vapier@gentoo.org>
Subject: Re: [gentoo-dev] [RFC] QA bashism check on portage
Date: Thu, 26 Feb 2009 10:27:44 +0100	[thread overview]
Message-ID: <200902261027.51235.drizzt@gentoo.org> (raw)
In-Reply-To: <200902251745.42989.vapier@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

On Wednesday 25 February 2009 23:45:41 Mike Frysinger wrote:
<cut>
> i recall it being incorrect in some cases (it checked for what dash
> supports, not what POSIX supports), but that was a while ago, so maybe my
> experience is dated at this point.  otherwise, integrating it sounds sane
> to me, and if we can push fixes back to debian, even better.

It does not fail, the problem is that some construct works only on some shells 
or systems (for example type and kill -HUP warnings).

Maybe we should add a getopt flag (-q for example) to mask that types of 
warnings, or maybe we should (for Gentoo/Alt) adapt files to be (almost) 
POSIX compliant (so command -v instead of type, kill -s HUP instead of 
kill -HUP, and go on)

> a repoman check on files in files/ would be useful as well i'd think

Yes, as supplementary check

-- 
Timothy `Drizzt` Redaelli
FreeSBIE Developer, Gentoo Developer, GUFI Staff
There are two major products that come out of Berkeley: LSD and UNIX.
We don't believe this to be a coincidence.      -- Jeremy S. Anderson

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2009-02-26  9:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 16:10 [gentoo-dev] [RFC] QA bashism check on portage Timothy Redaelli
2009-02-25 22:45 ` Mike Frysinger
2009-02-26  9:27   ` Timothy Redaelli [this message]
2009-02-26  9:32     ` Mike Frysinger
     [not found]       ` <200902261233.23823.drizzt@gentoo.org>
2009-02-26 15:08         ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902261027.51235.drizzt@gentoo.org \
    --to=drizzt@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox