public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Timothy Redaelli <drizzt@gentoo.org>
Subject: Re: [gentoo-dev] [RFC] QA bashism check on portage
Date: Wed, 25 Feb 2009 17:45:41 -0500	[thread overview]
Message-ID: <200902251745.42989.vapier@gentoo.org> (raw)
In-Reply-To: <200902251710.09258.drizzt@gentoo.org>

On Wednesday 25 February 2009 11:10:01 Timothy Redaelli wrote:
> what do you think about checking for bashism on install_qa_check?
> Obviously only for scripts with #!/bin/sh and #!/sbin/runscript as first
> line.
>
> I think checkbashisms.pl [1] could be a good start point.
>
> [1] http://svn.debian.org/viewsvn/devscripts/trunk/scripts/checkbashisms.pl

i recall it being incorrect in some cases (it checked for what dash supports, 
not what POSIX supports), but that was a while ago, so maybe my experience is 
dated at this point.  otherwise, integrating it sounds sane to me, and if we 
can push fixes back to debian, even better.

a repoman check on files in files/ would be useful as well i'd think
-mike



  reply	other threads:[~2009-02-25 22:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 16:10 [gentoo-dev] [RFC] QA bashism check on portage Timothy Redaelli
2009-02-25 22:45 ` Mike Frysinger [this message]
2009-02-26  9:27   ` Timothy Redaelli
2009-02-26  9:32     ` Mike Frysinger
     [not found]       ` <200902261233.23823.drizzt@gentoo.org>
2009-02-26 15:08         ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902251745.42989.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=drizzt@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox