From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LbwE9-00075D-7z for garchives@archives.gentoo.org; Tue, 24 Feb 2009 12:17:33 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 69D66E0334; Tue, 24 Feb 2009 12:17:32 +0000 (UTC) Received: from rv-out-0708.google.com (rv-out-0708.google.com [209.85.198.251]) by pigeon.gentoo.org (Postfix) with ESMTP id 3F688E0334 for ; Tue, 24 Feb 2009 12:17:32 +0000 (UTC) Received: by rv-out-0708.google.com with SMTP id f25so2485464rvb.46 for ; Tue, 24 Feb 2009 04:17:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=XXIHPvUyD0796rVjwoYfrtsyIsk3DYuz+f07feALt9w=; b=IDBwLMTDtZ7ZTUJAbnVxommIkQaosfWDfDDU++0PHF8MrapYTgHjLJ+Ok/oWQZpkc1 wTttBBoRUBpnDbUZo3yFxDE1u82nm91jCG3q8COngR/92RrjLqJTb8pxby5BpcaYbCge xazCTPmRznQyBcxyKnMiWPjjE13OOJ+1iUnUQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=U400B1D+8N/zJA1tO7Y5FZGwgSJTY3szy1w8yRntRl54bF/UZiwIm0/FQkCmsWoBXH YbF8Ro9ACPcWjJA01ui9n+qleFTC/qmXBHtF/4+uDdppy0tnJIdzztiW9q4Xlh93gvYR TTWoDm1I8JMA/1WQDLTCTAcBba+Dj0eu7DadI= Received: by 10.142.144.16 with SMTP id r16mr2501548wfd.214.1235477851824; Tue, 24 Feb 2009 04:17:31 -0800 (PST) Received: from smtp.gmail.com (c-98-210-196-21.hsd1.ca.comcast.net [98.210.196.21]) by mx.google.com with ESMTPS id 28sm13402465wfd.45.2009.02.24.04.17.29 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 24 Feb 2009 04:17:30 -0800 (PST) Received: by smtp.gmail.com (sSMTP sendmail emulation); Tue, 24 Feb 2009 04:18:08 -0800 Date: Tue, 24 Feb 2009 04:18:08 -0800 From: Brian Harring To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: bzr.eclass Message-ID: <20090224121808.GA3506@hrair> References: <20090214132152.2aff08a0@terra.solaris> <49970B3F.40809@gentoo.org> <499EA27D.5060608@necoro.eu> <20090223204528.636b5be9@terra.solaris> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline In-Reply-To: <20090223204528.636b5be9@terra.solaris> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: fcf4bbd3-a61f-4d41-80f6-125190c2715f X-Archives-Hash: b7e21b60562c6559a78b4852c85b1fae --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 23, 2009 at 08:45:28PM +0100, Christian Faulhammer wrote: > > if [[ ${EBZR_REPO_URI} =3D=3D */* ]]; then > > repository=3D"${EBZR_REPO_URI}/${EBZR_BRANCH}" > > elif [[ -n ${EBZR_BRANCH} ]] ; then > > ... > > else > > ... > > fi > >=20 > > If I see this correctly, this appends EBZR_BRANCH if there is a slash > > in the REPO_URI ... what kind of guess is this supposed to be? I > > think, the second test (append iff EBZR_BRANCH is set) should be > > sufficient. >=20 > Not sure, though I will investigate (and likely drop it). Kindly drop that; the REPO_URI/BRANCH seperation that is in use there=20 really isn't all that useful for bzr ebuilds in my experience- more=20 often then not it winds up biting me in the ass rather then being=20 useful. My usage (and understanding of bzr), there isn't a scenario where=20 seperation of the repo and branch applies- you only need the branch=20 uri, that encompasses it all (unlike cvs, where this probably was=20 inherited from). So... any reason to even have the var seperation like that? ~harring --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkmj5YAACgkQsiLx3HvNzgd10gCfdixncRccndzVpgpqzeoK8e9v 6FwAoNtFC4aqu2nrHolff2ZV2MZ/8jMb =NMXu -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--