public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Time to remove app-shells/bash-completion-config
@ 2009-02-17 17:55 Jeremy Olexa
  2009-02-17 19:49 ` Donnie Berkholz
  2009-02-20  6:18 ` [gentoo-dev] " Jeremy Olexa
  0 siblings, 2 replies; 5+ messages in thread
From: Jeremy Olexa @ 2009-02-17 17:55 UTC (permalink / raw
  To: gentoo-dev

Hello,
I would like to request that bash-completion-20081218 to be marked
stable by the arches soon here.

In doing so, I'm going to make the following change to bash-completion.eclass:

-RDEPEND="bash-completion?
-               ( || (
-                       app-admin/eselect
-                       app-shells/bash-completion-config
-                       )
-               )"
+RDEPEND="bash-completion? ( app-admin/eselect )"

We should only be using eselect now to enable bash-completion. I think
bash-completion-config is broken now anyway
(https://bugs.gentoo.org/show_bug.cgi?id=253878). So, after this
change, I will p.mask b-c-c for removal.

Any concerns? The upgrade path in the future is going to be wierd as
upstream is releasing v1.0 soon, but that is not concern for now.
Thanks,
Jeremy



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [gentoo-dev] Time to remove app-shells/bash-completion-config
  2009-02-17 17:55 [gentoo-dev] Time to remove app-shells/bash-completion-config Jeremy Olexa
@ 2009-02-17 19:49 ` Donnie Berkholz
  2009-02-17 20:27   ` Jeremy Olexa
  2009-02-20  6:18 ` [gentoo-dev] " Jeremy Olexa
  1 sibling, 1 reply; 5+ messages in thread
From: Donnie Berkholz @ 2009-02-17 19:49 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

On 11:55 Tue 17 Feb     , Jeremy Olexa wrote:
> We should only be using eselect now to enable bash-completion. I think
> bash-completion-config is broken now anyway
> (https://bugs.gentoo.org/show_bug.cgi?id=253878). So, after this
> change, I will p.mask b-c-c for removal.
> 
> Any concerns? The upgrade path in the future is going to be wierd as
> upstream is releasing v1.0 soon, but that is not concern for now.

http://bugs.gentoo.org/show_bug.cgi?id=218557

[Comment #0] mescalinum@gentoo.org : 2008-04-20 12:26:38 0000
-------------------------------------------------------------------------------
if I type:

 eselect bashcomp enable [TAB]

I get a 'Killed' string printed to terminal:

 eselect bashcomp enable Killed

and it messes up the bash shell (i.e. history doesn't work anymore)

[Comment #3] w.schwiedop@web.de : 2008-07-31 00:41:39 0000
-------------------------------------------------------------------------------
Created an attachment (id=161784)
Replacement for the current eselect completion script


-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [gentoo-dev] Time to remove app-shells/bash-completion-config
  2009-02-17 19:49 ` Donnie Berkholz
@ 2009-02-17 20:27   ` Jeremy Olexa
  2009-02-17 20:35     ` Ciaran McCreesh
  0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Olexa @ 2009-02-17 20:27 UTC (permalink / raw
  To: gentoo-dev

On Tue, Feb 17, 2009 at 1:49 PM, Donnie Berkholz <dberkholz@gentoo.org> wrote:
> On 11:55 Tue 17 Feb     , Jeremy Olexa wrote:
>> We should only be using eselect now to enable bash-completion. I think
>> bash-completion-config is broken now anyway
>> (https://bugs.gentoo.org/show_bug.cgi?id=253878). So, after this
>> change, I will p.mask b-c-c for removal.
>>
>> Any concerns? The upgrade path in the future is going to be wierd as
>> upstream is releasing v1.0 soon, but that is not concern for now.
>
> http://bugs.gentoo.org/show_bug.cgi?id=218557
>
> [Comment #0] mescalinum@gentoo.org : 2008-04-20 12:26:38 0000
> -------------------------------------------------------------------------------
> if I type:
>
>  eselect bashcomp enable [TAB]
>
> I get a 'Killed' string printed to terminal:
>
>  eselect bashcomp enable Killed
>
> and it messes up the bash shell (i.e. history doesn't work anymore)
>
> [Comment #3] w.schwiedop@web.de : 2008-07-31 00:41:39 0000
> -------------------------------------------------------------------------------
> Created an attachment (id=161784)
> Replacement for the current eselect completion script

This is not a fault of bash-completion but rather the eselect
bash-completion module itself. Since our eselect team is defunct, I
will mask the bash-completion USE flag for app-admin/eselect unless
someone steps up to take care of it (working patches exist, anyone?).
Analogy: If subversion's bash-completion module was broken, it
wouldn't block anything to do with app-shells/bash-completion. Instead
you would work it out with upstream.

Also: *enabling* bash-completion modules via eselect works just fine.
So, I don't get why this reply was needed on this thread.

-Jeremy



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [gentoo-dev] Time to remove app-shells/bash-completion-config
  2009-02-17 20:27   ` Jeremy Olexa
@ 2009-02-17 20:35     ` Ciaran McCreesh
  0 siblings, 0 replies; 5+ messages in thread
From: Ciaran McCreesh @ 2009-02-17 20:35 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

On Tue, 17 Feb 2009 14:27:24 -0600
Jeremy Olexa <darkside@gentoo.org> wrote:
> This is not a fault of bash-completion but rather the eselect
> bash-completion module itself. Since our eselect team is defunct, I
> will mask the bash-completion USE flag for app-admin/eselect unless
> someone steps up to take care of it (working patches exist, anyone?).

*cough* fixed in eclectic *cough*

Unfortunately Cardoe hasn't followed through on his plans to move
Gentoo over...

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [gentoo-dev] Re: Time to remove app-shells/bash-completion-config
  2009-02-17 17:55 [gentoo-dev] Time to remove app-shells/bash-completion-config Jeremy Olexa
  2009-02-17 19:49 ` Donnie Berkholz
@ 2009-02-20  6:18 ` Jeremy Olexa
  1 sibling, 0 replies; 5+ messages in thread
From: Jeremy Olexa @ 2009-02-20  6:18 UTC (permalink / raw
  To: gentoo-dev

On Tue, Feb 17, 2009 at 11:55 AM, Jeremy Olexa <darkside@gentoo.org> wrote:
> Hello,
> I would like to request that bash-completion-20081218 to be marked
> stable by the arches soon here.
>
> In doing so, I'm going to make the following change to bash-completion.eclass:
>
> -RDEPEND="bash-completion?
> -               ( || (
> -                       app-admin/eselect
> -                       app-shells/bash-completion-config
> -                       )
> -               )"
> +RDEPEND="bash-completion? ( app-admin/eselect )"

Done. Use app-admin/eselect to enable bash completion modules.

-Jeremy



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-02-20  6:18 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-17 17:55 [gentoo-dev] Time to remove app-shells/bash-completion-config Jeremy Olexa
2009-02-17 19:49 ` Donnie Berkholz
2009-02-17 20:27   ` Jeremy Olexa
2009-02-17 20:35     ` Ciaran McCreesh
2009-02-20  6:18 ` [gentoo-dev] " Jeremy Olexa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox