From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LYNCz-0002Y0-7p for garchives@archives.gentoo.org; Sat, 14 Feb 2009 16:17:37 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 440E7E03D0; Sat, 14 Feb 2009 16:17:36 +0000 (UTC) Received: from mo-p05-ob.rzone.de (mo-p05-ob.rzone.de [81.169.146.182]) by pigeon.gentoo.org (Postfix) with ESMTP id C956CE03D0 for ; Sat, 14 Feb 2009 16:17:35 +0000 (UTC) X-RZG-AUTH: :K2kKYU+nW/MMMlTokcN5Yot1/Bj/FTl+WviP6RIJci0HRMpbh/x+X6ShOQjVOj0+68zRLwoBNG8= X-RZG-CLASS-ID: mo05 Received: from terra.solaris (p54AE56B1.dip.t-dialin.net [84.174.86.177]) by post.strato.de (klopstock mo16) (RZmta 18.18) with ESMTP id L020b0l1EEKTaI for ; Sat, 14 Feb 2009 17:17:34 +0100 (MET) Date: Sat, 14 Feb 2009 17:15:49 +0100 From: Christian Faulhammer To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: bzr.eclass Message-ID: <20090214171549.3abcc3e7@terra.solaris> In-Reply-To: <18838.58666.595076.725315@a1ihome1.kph.uni-mainz.de> References: <20090214132152.2aff08a0@terra.solaris> <18838.58666.595076.725315@a1ihome1.kph.uni-mainz.de> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.12.11; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Jj87ToYJJvQw00G2fVsMTtG"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Archives-Salt: def7e68d-0679-4984-a3e2-0592e5368c10 X-Archives-Hash: ec7759c92fb63c8aaa299690fdf7151f --Sig_/Jj87ToYJJvQw00G2fVsMTtG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi, Ulrich Mueller : > >>>>> On Sat, 14 Feb 2009, Christian Faulhammer wrote: >=20 > > Please review the attached patch. >=20 > + local repo_type=3D3D$(bzr info "${EBZR_BRANCH_DIR}" | > head -n 1 | cut -d '=3D (' -f 1) > + if [[ "${repo_type}" !=3D3D "Lightweight checkout > " ]]; then >=20 > This test looks very fragile to me. Could it be replaced by something > else? The refetching of old full checkouts is not needed, just a neat feature. After looking at the repository structure a different test could be the existence of .bzr/repository...lightweight checkouts don't have it. V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/Jj87ToYJJvQw00G2fVsMTtG Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkmW7jUACgkQNQqtfCuFnePZ3ACdGrE72XFlZg0U4wKNXd2Ys7TB kAwAnRCns8CbJNTWndGtd+XjNqUAqTcq =wrJN -----END PGP SIGNATURE----- --Sig_/Jj87ToYJJvQw00G2fVsMTtG--