* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-chemistry/gromacs: gromacs-3.3.3.ebuild gromacs-4.0.3.ebuild ChangeLog gromacs-4.0.ebuild gromacs-3.3.1-r1.ebuild gromacs-4.0.2.ebuild
[not found] <E1LPqxg-00014D-Ot@stork.gentoo.org>
@ 2009-01-22 4:53 ` Donnie Berkholz
0 siblings, 0 replies; only message in thread
From: Donnie Berkholz @ 2009-01-22 4:53 UTC (permalink / raw
To: gentoo-dev, je_fro
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On 04:14 Thu 22 Jan , Jeffrey Gardner (je_fro) wrote:
> Index: gromacs-4.0.3.ebuild
> if ( use double-precision ) ; then
What is this pointless subshell doing? There's heavy use of subshells
throughout this ebuild for no reason. I quoted them below when I saw
them.
> if ( use sse || use sse2 ) ; then
> if ( ! use sse && ! use sse2 && ! use 3dnow ) ; then
> # if we need external blas
I really hope the other option is not internal blas. If so, it shouldn't
be an option at all. Same goes for lapack.
> if ( use double-precision && use single-precision ); then
--
Thanks,
Donnie
Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] only message in thread