From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LPrZr-000693-P8 for garchives@archives.gentoo.org; Thu, 22 Jan 2009 04:54:04 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9C5B1E046F; Thu, 22 Jan 2009 04:54:00 +0000 (UTC) Received: from smtp6.oregonstate.edu (smtp6.oregonstate.edu [128.193.15.46]) by pigeon.gentoo.org (Postfix) with ESMTP id 724BDE046F for ; Thu, 22 Jan 2009 04:54:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp6.oregonstate.edu (Postfix) with ESMTP id C9039C88659; Wed, 21 Jan 2009 20:53:59 -0800 (PST) X-Virus-Scanned: amavisd-new at oregonstate.edu Received: from smtp6.oregonstate.edu ([127.0.0.1]) by localhost (smtp.oregonstate.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id caArNE28QXS1; Wed, 21 Jan 2009 20:53:59 -0800 (PST) Received: from xray.science.oregonstate.edu (xray.science.oregonstate.edu [128.193.220.51]) by smtp6.oregonstate.edu (Postfix) with ESMTP id 9984CC88650; Wed, 21 Jan 2009 20:53:59 -0800 (PST) Received: by xray.science.oregonstate.edu (Postfix, from userid 1194) id 9591610D1346; Wed, 21 Jan 2009 20:53:59 -0800 (PST) Date: Wed, 21 Jan 2009 20:53:59 -0800 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org, je_fro@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-chemistry/gromacs: gromacs-3.3.3.ebuild gromacs-4.0.3.ebuild ChangeLog gromacs-4.0.ebuild gromacs-3.3.1-r1.ebuild gromacs-4.0.2.ebuild Message-ID: <20090122045359.GC9101@hermes> References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="JgQwtEuHJzHdouWu" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Archives-Salt: f6255075-f4aa-4e1e-b97f-995a6acc8315 X-Archives-Hash: 95ab2f7693c42c514778a2ee61032676 --JgQwtEuHJzHdouWu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 04:14 Thu 22 Jan , Jeffrey Gardner (je_fro) wrote: > Index: gromacs-4.0.3.ebuild > if ( use double-precision ) ; then What is this pointless subshell doing? There's heavy use of subshells=20 throughout this ebuild for no reason. I quoted them below when I saw=20 them. > if ( use sse || use sse2 ) ; then > if ( ! use sse && ! use sse2 && ! use 3dnow ) ; then > # if we need external blas I really hope the other option is not internal blas. If so, it shouldn't=20 be an option at all. Same goes for lapack. > if ( use double-precision && use single-precision ); then --=20 Thanks, Donnie Donnie Berkholz Developer, Gentoo Linux Blog: http://dberkholz.wordpress.com --JgQwtEuHJzHdouWu Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkl3++cACgkQXVaO67S1rtuPZgCfQrCJUOZisociWKpCf67AYCG7 SEEAoIs/PBt26EbPnZ+6nXmhzt4rPS/X =fW9V -----END PGP SIGNATURE----- --JgQwtEuHJzHdouWu--