From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LOy4Z-0002bU-93 for garchives@archives.gentoo.org; Mon, 19 Jan 2009 17:38:03 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EB35FE052D; Mon, 19 Jan 2009 17:38:00 +0000 (UTC) Received: from smtp6.oregonstate.edu (smtp6.oregonstate.edu [128.193.15.46]) by pigeon.gentoo.org (Postfix) with ESMTP id A5994E052D for ; Mon, 19 Jan 2009 17:38:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp6.oregonstate.edu (Postfix) with ESMTP id 0D06AC886B6; Mon, 19 Jan 2009 09:38:00 -0800 (PST) X-Virus-Scanned: amavisd-new at oregonstate.edu Received: from smtp6.oregonstate.edu ([127.0.0.1]) by localhost (smtp.oregonstate.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EdJOM+fCY7JU; Mon, 19 Jan 2009 09:37:59 -0800 (PST) Received: from xray.science.oregonstate.edu (xray.science.oregonstate.edu [128.193.220.51]) by smtp6.oregonstate.edu (Postfix) with ESMTP id D0479C886B5; Mon, 19 Jan 2009 09:37:59 -0800 (PST) Received: by xray.science.oregonstate.edu (Postfix, from userid 1194) id CA8EF10D1345; Mon, 19 Jan 2009 09:37:59 -0800 (PST) Date: Mon, 19 Jan 2009 09:37:59 -0800 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org, iluxa@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-cpp/sptk: ChangeLog sptk-3.5.8.9.ebuild Message-ID: <20090119173759.GB4552@hermes> References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Archives-Salt: 5ac156bb-5ede-4083-90b4-d2153b5eba52 X-Archives-Hash: fae8d13ad5cea50814736f0cb1083ec6 --neYutvxvOLaeuPCA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11:11 Mon 19 Jan , Ilya Volynets (iluxa) wrote: > 1.1 dev-cpp/sptk/sptk-3.5.8.9.ebuild >=20 > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-cpp/sptk/sptk-= 3.5.8.9.ebuild?rev=3D1.1&view=3Dmarkup > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-cpp/sptk/sptk-= 3.5.8.9.ebuild?rev=3D1.1&content-type=3Dtext/plain > LICENSE=3D"|| ( BSD )" What's going on here? Looks like an alternate license might've been=20 dropped. > check_use() { > if use ${1}; then > SPTK_OPTIONS=3D"${SPTK_OPTIONS} -DNO_${2}:BOOLEAN=3DFALSE" > else > SPTK_OPTIONS=3D"${SPTK_OPTIONS} -DNO_${2}:BOOLEAN=3DTRUE" > fi > } I would rename or rewrite this function. It's not just checking and=20 returning 0 or 1 as the name implies -- it's setting a global variable. > src_install () { >=20 > make DESTDIR=3D"${D}" install || die "Installation failed" emake, please. With -j1 and a comment pointing to the upstream bug if it=20 fails. > dodir /usr/share/doc/${PF} > cp -r "${S}"/docs/* "${D}"/usr/share/doc/${PF} > if use doc; then > rm -fr "${D}/usr/share/doc/${PF}/latex" > cp -rf "${S}/pictures" "${D}/usr/share/doc/${PF}" > fi Does this need a prepalldocs or does that happen automatically? I'm not=20 on a Gentoo system atm to check. --=20 Thanks, Donnie Donnie Berkholz Developer, Gentoo Linux Blog: http://dberkholz.wordpress.com --neYutvxvOLaeuPCA Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkl0uncACgkQXVaO67S1rtsGMACff1mWOT3FXhTGHUP/Whtr6G6v NnkAoLnr3I55MHdFgKOUu+GNPvzVvv4V =ggNi -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--