[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-cpp/sptk: ChangeLog sptk-3.5.8.9.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-cpp/sptk: ChangeLog sptk-3.5.8.9.ebuild

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

On 11:11 Mon 19 Jan     , Ilya Volynets (iluxa) wrote:
> 1.1                  dev-cpp/sptk/sptk-3.5.8.9.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-cpp/sptk/sptk-3.5.8.9.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-cpp/sptk/sptk-3.5.8.9.ebuild?rev=1.1&content-type=text/plain

> LICENSE="|| ( BSD )"

What's going on here? Looks like an alternate license might've been 
dropped.

> check_use() {
> 	if use ${1}; then
> 		SPTK_OPTIONS="${SPTK_OPTIONS} -DNO_${2}:BOOLEAN=FALSE"
> 	else
> 		SPTK_OPTIONS="${SPTK_OPTIONS} -DNO_${2}:BOOLEAN=TRUE"
> 	fi
> }

I would rename or rewrite this function. It's not just checking and 
returning 0 or 1 as the name implies -- it's setting a global variable.

> src_install () {
> 
> 	make DESTDIR="${D}" install || die "Installation failed"

emake, please. With -j1 and a comment pointing to the upstream bug if it 
fails.

> 	dodir /usr/share/doc/${PF}
> 	cp -r "${S}"/docs/* "${D}"/usr/share/doc/${PF}
> 	if use doc; then
> 		rm -fr "${D}/usr/share/doc/${PF}/latex"
> 		cp -rf "${S}/pictures" "${D}/usr/share/doc/${PF}"
> 	fi

Does this need a prepalldocs or does that happen automatically? I'm not 
on a Gentoo system atm to check.

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]