From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-34036-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1LOkP3-0004CZ-Te
	for garchives@archives.gentoo.org; Mon, 19 Jan 2009 03:02:18 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 794E8E0352;
	Mon, 19 Jan 2009 03:02:14 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	by pigeon.gentoo.org (Postfix) with ESMTP id 4DCDEE0352
	for <gentoo-dev@lists.gentoo.org>; Mon, 19 Jan 2009 03:02:14 +0000 (UTC)
Received: from gentoo.org (c-98-246-79-112.hsd1.or.comcast.net [98.246.79.112])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp.gentoo.org (Postfix) with ESMTP id C15FC64614
	for <gentoo-dev@lists.gentoo.org>; Mon, 19 Jan 2009 03:02:10 +0000 (UTC)
Date: Sun, 18 Jan 2009 19:02:10 -0800
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] New eclass: go-mono.eclass
Message-ID: <20090119030209.GB3562@comet>
References: <200901162103.27740.loki_val@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="i0/AhcQY5QxfSsSZ"
Content-Disposition: inline
In-Reply-To: <200901162103.27740.loki_val@gentoo.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
X-Archives-Salt: 5929f6d6-3a5a-4bc3-9170-3de47f9d4e95
X-Archives-Hash: fbf8d7e2f9aed5fee01b74c061b51ed9


--i0/AhcQY5QxfSsSZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 21:03 Fri 16 Jan     , Peter Alfredsen wrote:
> NO_MONO_DEPEND=3D(
> 	"dev-lang/mono"
> 	"dev-dotnet/libgdiplus"
> 	"dev-dotnet/gluezilla"
> )

I'm not a huge fan of having package-specific logic in eclasses. This=20
would be nicer to see as a variable set in the packages like=20
MONO_DEPEND=3D"no". That would also get rid of the double-negative logic=20
below:

> if ! has "${CATEGORY}/${PN}" "${NO_MONO_DEPEND[@]}"
> then
> 	RDEPEND=3D"=3Ddev-lang/mono-${GO_MONO_REL_PV}*"
> 	DEPEND=3D"${RDEPEND}"
> fi


> if [[ "${PV%_rc*}" !=3D "${PV}" ]]
> then
> 	GO_MONO_P=3D"${P%_rc*}"
> 	SRC_URI=3D"${PRE_URI}/${PN}/${GO_MONO_P} -> ${P}.tar.bz2"
> 	S=3D"${WORKDIR}/${GO_MONO_P}"
> elif [[ "${PV%_pre*}" !=3D "${PV}" ]]
> then
> 	GO_MONO_P=3D"${P%_pre*}"
> 	SRC_URI=3D"${PRE_URI}/${PN}/${GO_MONO_P} -> ${P}.tar.bz2"
> 	S=3D"${WORKDIR}/${GO_MONO_P}"
> else
> 	GO_MONO_P=3D${P}
> 	SRC_URI=3D"http://ftp.novell.com/pub/mono/sources/${PN}/${P}.tar.bz2"
> fi

How about GO_MONO_P=3D${P%_[a-z]*} -- doesn't that work in all cases?

--=20
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

--i0/AhcQY5QxfSsSZ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iEYEABECAAYFAklz7TEACgkQXVaO67S1rtvC7QCfUxOvcYK4pN+cMjlvycpWk4HO
v7MAoPBFULO41I62a1+kHKc8jHEletWu
=75kk
-----END PGP SIGNATURE-----

--i0/AhcQY5QxfSsSZ--