From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LA824-0001Tk-Tg for garchives@archives.gentoo.org; Tue, 09 Dec 2008 19:14:09 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9724AE03CE; Tue, 9 Dec 2008 19:14:06 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 6FDBBE03CE for ; Tue, 9 Dec 2008 19:14:06 +0000 (UTC) Received: from gentoo.org (xray.science.oregonstate.edu [128.193.220.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 09A85648B8 for ; Tue, 9 Dec 2008 19:14:06 +0000 (UTC) Date: Tue, 9 Dec 2008 11:14:05 -0800 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Proposal for flag-o-matic.eclass (append-ldflags) Message-ID: <20081209191405.GC2455@comet> References: <90b936c0812080833q1079ea5bsaf48a8b7b703ad64@mail.gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Izn7cH1Com+I3R9J" Content-Disposition: inline In-Reply-To: <90b936c0812080833q1079ea5bsaf48a8b7b703ad64@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Archives-Salt: 5e9854bd-0e7a-4ce1-a1c3-501da5ae3015 X-Archives-Hash: fc528f4e9790b0e0671510261e973181 --Izn7cH1Com+I3R9J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 10:33 Mon 08 Dec , Jeremy Olexa wrote: > Hello, > I am seeking a positive code review on the following change to > flag-o-matic.eclass, diff is below (reasons are below that): >=20 > %% cvs diff > Index: flag-o-matic.eclass > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v > retrieving revision 1.126 > diff -u -r1.126 flag-o-matic.eclass > --- flag-o-matic.eclass 3 Nov 2008 05:52:39 -0000 1.126 > +++ flag-o-matic.eclass 25 Nov 2008 18:36:04 -0000 > @@ -417,7 +417,8 @@ >=20 > x=3D"" > for x in "$@" ; do > - test-flag-${comp} "${x}" && flags=3D"${flags}${flags:+ }$= {x}" > + test-flag-${comp} "${x}" && flags=3D"${flags}${flags:+ }$= {x}" || \ > + ewarn "removing ${x} because ${comp} rejected it" > done >=20 > echo "${flags}" > @@ -656,7 +657,7 @@ > ewarn "Appending a library link instruction > (${flag}); libraries to link to should not be passed through LDFLAGS" > done >=20 > - export LDFLAGS=3D"${LDFLAGS} $*" > + export LDFLAGS=3D"${LDFLAGS} $(test-flags "$@")" > return 0 > } I like the consistency with other flags: comet $ grep FLAGS.*test-fl /usr/portage/eclass/flag-o-matic.eclass=20 export CFLAGS=3D$(test-flags-CC ${CFLAGS}) export CXXFLAGS=3D$(test-flags-CXX ${CXXFLAGS}) export FFLAGS=3D$(test-flags-F77 ${FFLAGS}) export FCFLAGS=3D$(test-flags-FC ${FCFLAGS}) --=20 Thanks, Donnie Donnie Berkholz Developer, Gentoo Linux Blog: http://dberkholz.wordpress.com --Izn7cH1Com+I3R9J Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkk+w30ACgkQXVaO67S1rtvmswCfV8yWD0j11c3rBKLpqxrZr3GG ErQAmgMtqWwsOZ2/SpiXr3bJJ4jLapUd =D5h6 -----END PGP SIGNATURE----- --Izn7cH1Com+I3R9J--