[gentoo-dev] Please avoid absolute paths in patched filenames

[gentoo-dev] Please avoid absolute paths in patched filenames

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1: Type: text/plain, Size: 902 bytes --]


I ask it here as a favour, please avoid using absolute paths in the
filenames of patched files. This mean avoid having stuff like

--- foobar/foo.c
+++ /tmp/foobar/foobar.c

This tends to break from time to time, and I had to fix at least three
packages since I started my treewide build for these problems. I already
asked Zac about adding such a check on repoman, but in the mean time I'd
like to ask here for people to verify their packages.

I actually am culprit of doing this some time ago but I learnt my lesson
the hard way :P My suggestion for everybody else is to use quilt when
you need to write patches.

And if you have patches with the filenames like I shown above, you can
change it the git way so that it becomes:

--- a/foobar/foo.c
+++ b/foobar/foo.c

and the problem is usually solved.

Thanks,
-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/


[-- Attachment #2: Type: application/pgp-signature, Size: 196 bytes --]

Re: [gentoo-dev] Please avoid absolute paths in patched filenames

[Serkan Kaba]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

This check was added to epatch all of a sudden breaking all working
patches in the tree, although defending those patches having absolute
paths, we as Java team had several bugs filed due to that. Maybe the
tree should be scanned for those and fixed.

Diego 'Flameeyes' Pettenò yazmış:
> I ask it here as a favour, please avoid using absolute paths in the
> filenames of patched files. This mean avoid having stuff like
> 
> --- foobar/foo.c
> +++ /tmp/foobar/foobar.c
> 
> This tends to break from time to time, and I had to fix at least three
> packages since I started my treewide build for these problems. I already
> asked Zac about adding such a check on repoman, but in the mean time I'd
> like to ask here for people to verify their packages.
> 
> I actually am culprit of doing this some time ago but I learnt my lesson
> the hard way :P My suggestion for everybody else is to use quilt when
> you need to write patches.
> 
> And if you have patches with the filenames like I shown above, you can
> change it the git way so that it becomes:
> 
> --- a/foobar/foo.c
> +++ b/foobar/foo.c
> 
> and the problem is usually solved.
> 
> Thanks,

- --
Sincerely,
Serkan KABA
Gentoo/Java
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkhxhgACgkQRh6X64ivZaK4wwCeIUCZ6BIqWvo7tiFXpXa+Njpe
AL4An2E5N+yGaIfv1kPaV4Gc9W8DG3M3
=2nhY
-----END PGP SIGNATURE-----

[gentoo-dev] Re: Please avoid absolute paths in patched filenames

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Serkan Kaba <serkan@gentoo.org> writes:

> This check was added to epatch all of a sudden breaking all working
> patches in the tree, although defending those patches having absolute
> paths, we as Java team had several bugs filed due to that. Maybe the
> tree should be scanned for those and fixed.

Fun, I didn't really notice it was an epatch specific code that failed,
I know it fails when the paths don't add up between systems and I
thought that was it.. Okay, I guess I'll get to fix the rest tonight
after Bones...

-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/

[-- Attachment #2: Type: application/pgp-signature, Size: 196 bytes --]

[gentoo-dev] Re: Please avoid absolute paths in patched filenames

[Diego 'Flameeyes' Pettenò]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

flameeyes@gmail.com (Diego 'Flameeyes' Pettenò) writes:

> Fun, I didn't really notice it was an epatch specific code that failed,
> I know it fails when the paths don't add up between systems and I
> thought that was it.. Okay, I guess I'll get to fix the rest tonight
> after Bones...

All the tree should be sanitised now for what concerns patches in
$FILESDIR ... It's up to you to see if there are broken patches on
mirrors, I guess. My tinderbox will try its best to find them anyway.

-- 
Diego "Flameeyes" Pettenò
http://blog.flameeyes.eu/

[-- Attachment #2: Type: application/pgp-signature, Size: 196 bytes --]

Re: [gentoo-dev] Please avoid absolute paths in patched filenames

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]

On Mon, 2008-11-17 at 20:24 +0100, Diego 'Flameeyes' Pettenò wrote:
> I ask it here as a favour, please avoid using absolute paths in the
> filenames of patched files. This mean avoid having stuff like
> 
> --- foobar/foo.c
> +++ /tmp/foobar/foobar.c
> 
> This tends to break from time to time, and I had to fix at least three
> packages since I started my treewide build for these problems. I already
> asked Zac about adding such a check on repoman, but in the mean time I'd
> like to ask here for people to verify their packages.
> 
> I actually am culprit of doing this some time ago but I learnt my lesson
> the hard way :P My suggestion for everybody else is to use quilt when
> you need to write patches.
> 
> And if you have patches with the filenames like I shown above, you can
> change it the git way so that it becomes:
> 
> --- a/foobar/foo.c
> +++ b/foobar/foo.c
> 
> and the problem is usually solved.

Could you please expand on what the actual problem is for reference,
having never seen them fail myself or hear any fail for others?


-- 
Mart Raudsepp
Gentoo Developer
Mail: leio@gentoo.org
Weblog: http://planet.gentoo.org/developers/leio

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [gentoo-dev] Please avoid absolute paths in patched filenames

[Serkan Kaba]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mart Raudsepp yazmış:
> On Mon, 2008-11-17 at 20:24 +0100, Diego 'Flameeyes' Pettenò wrote:
>> I ask it here as a favour, please avoid using absolute paths in the
>> filenames of patched files. This mean avoid having stuff like
>>
>> --- foobar/foo.c
>> +++ /tmp/foobar/foobar.c
>>
>> This tends to break from time to time, and I had to fix at least three
>> packages since I started my treewide build for these problems. I already
>> asked Zac about adding such a check on repoman, but in the mean time I'd
>> like to ask here for people to verify their packages.
>>
>> I actually am culprit of doing this some time ago but I learnt my lesson
>> the hard way :P My suggestion for everybody else is to use quilt when
>> you need to write patches.
>>
>> And if you have patches with the filenames like I shown above, you can
>> change it the git way so that it becomes:
>>
>> --- a/foobar/foo.c
>> +++ b/foobar/foo.c
>>
>> and the problem is usually solved.
> 
> Could you please expand on what the actual problem is for reference,
> having never seen them fail myself or hear any fail for others?
> 
> 

See bug #237667 and dev-thread
http://archives.gentoo.org/gentoo-dev/msg_777d416bb082a45b0e4848d8db5bfec8.xml

- --
Sincerely,
Serkan KABA
Gentoo/Java
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkiSXEACgkQRh6X64ivZaJfgACfbA/wjlEoldGyZUaDev0jXyng
/SkAoIHS1c8x2bAHbeFDO+r4M8NIK++R
=+Ho/
-----END PGP SIGNATURE-----

Re: [gentoo-dev] Re: Please avoid absolute paths in patched filenames

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

On Monday 17 November 2008 18:14:02 Diego 'Flameeyes' Pettenò wrote:
> flameeyes@gmail.com (Diego 'Flameeyes' Pettenò) writes:
> > Fun, I didn't really notice it was an epatch specific code that failed,
> > I know it fails when the paths don't add up between systems and I
> > thought that was it.. Okay, I guess I'll get to fix the rest tonight
> > after Bones...
>
> All the tree should be sanitised now for what concerns patches in
> $FILESDIR ... It's up to you to see if there are broken patches on
> mirrors, I guess. My tinderbox will try its best to find them anyway.

thanks ... i imagine that was anything but fun
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]