From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KxnPc-0004pz-2z for garchives@archives.gentoo.org; Wed, 05 Nov 2008 18:47:28 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CB64FE058E; Wed, 5 Nov 2008 18:46:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id A2A85E058E for ; Wed, 5 Nov 2008 18:46:59 +0000 (UTC) Received: from 0x3ef266d2.svgnxx4.dynamic.dsl.tele.dk (0x3ef266d2.svgnxx4.dynamic.dsl.tele.dk [62.242.102.210]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id A66DD64562 for ; Wed, 5 Nov 2008 18:46:57 +0000 (UTC) From: Peter Alfredsen To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Proposed change to base.eclass: EAPI-2 support Date: Wed, 5 Nov 2008 20:45:30 +0200 User-Agent: KMail/1.9.10 References: <200811022308.49072.loki_val@gentoo.org> <200811032053.59249.loki_val@gentoo.org> <4911E54D.6090008@gentoo.org> In-Reply-To: <4911E54D.6090008@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1340900.odWIhjuer7"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200811051945.32471.loki_val@gentoo.org> X-Archives-Salt: 70c5c14a-a1bf-42c4-8507-cce2546b2db9 X-Archives-Hash: 2a8fd036bd68003c438cc79d8765669a --nextPart1340900.odWIhjuer7 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 05 November 2008, Thomas Sachau wrote: > You should at least use emake instead of make in src_install. And i > would suggest to use something like this instead of the make install > line (maybe add some other default docs, if they are common): > > if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then > emake DESTDIR=3D"${D}" install || die "emake install failed" > fi > if [ -n "${DOCS}" ]; then > dodoc ${DOCS} || die "dodoc failed" > else > for x in AUTHORS ChangeLog NEWS README; do > if [ -e ${x} ]; then > dodoc ${x} || die "dodoc ${x} failed" > fi > done > fi I only propose changes to update the base.eclass to using EAPI-2=20 functions, IOW the above is outside the scope of what I propose. Besides, using emake instead of make is not a good change to make to an=20 eclass unless you know for a fact that all ebuilds using the eclass=20 have parallel make friendly makefiles. And even then... =2D-=20 /PA --nextPart1340900.odWIhjuer7 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkkR6cwACgkQtEGUx4TfHiSP1ACgmB0lDhmyBa4iKzFJv0YP/fYC YGAAnRI8oN0bB/W55LzdFKuPZv4eGYXe =72yW -----END PGP SIGNATURE----- --nextPart1340900.odWIhjuer7--