From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-33266-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1KvwiV-0006h6-Iz
	for garchives@archives.gentoo.org; Fri, 31 Oct 2008 16:19:20 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id BEEEDE0103;
	Fri, 31 Oct 2008 16:19:18 +0000 (UTC)
Received: from server1.tmkis.com (server1.tmkis.com [62.216.179.226])
	by pigeon.gentoo.org (Postfix) with ESMTP id 9619EE0103
	for <gentoo-dev@lists.gentoo.org>; Fri, 31 Oct 2008 16:19:18 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by server1.tmkis.com (Postfix) with ESMTP id F0A73E40F4;
	Fri, 31 Oct 2008 17:19:15 +0100 (CET)
Received: from server1.tmkis.com ([127.0.0.1])
	by localhost (server1.tmkis.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 03106-01; Fri, 31 Oct 2008 17:19:15 +0100 (CET)
Received: from arkane.local (p3EE085B4.dip0.t-ipconnect.de [62.224.133.180])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by server1.tmkis.com (Postfix) with ESMTP id 54BF4E40E0;
	Fri, 31 Oct 2008 17:19:15 +0100 (CET)
Received: by arkane.local (Postfix, from userid 1000)
	id 4A01B8872; Fri, 31 Oct 2008 17:18:46 +0100 (CET)
Date: Fri, 31 Oct 2008 17:18:46 +0100
From: Torsten Veller <ml-en@veller.net>
To: gentoo-dev@lists.gentoo.org, chainsaw@gentoo.org
Subject: [gentoo-dev] Re: gentoo-x86 commit in app-mobilephone/smstools: ChangeLog
	smstools-2.2.20.ebuild
Message-ID: <20081031170932.TA2bdf6.tv@veller.net>
Mail-Followup-To: gentoo-dev@lists.gentoo.org, chainsaw@gentoo.org
References: <E1KvwFd-0005EP-27@stork.gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E1KvwFd-0005EP-27@stork.gentoo.org>
Jabber-ID: tove@jabber.ccc.de
X-PGP-Fingerprint: 0416 3C11 8D79 65B9 AAD0 2065 BBC7 14D1 9C67 CD96
User-Agent: Mutt/1.5.18 (2008-10-20)
X-Archives-Salt: a0d9d8fa-420f-4263-8360-6c3546b26e0a
X-Archives-Hash: 3dc207418af454c0da57327b127cc585

* "Tony Vroon (chainsaw)" <chainsaw@gentoo.org>:
> diff -u -r1.1 -r1.2
> --- smstools-2.2.20.ebuild	14 Jan 2008 16:13:37 -0000	1.1
> +++ smstools-2.2.20.ebuild	31 Oct 2008 15:49:29 -0000	1.2
>  
> -pkg_setup() {
> -	enewgroup sms
> -	enewuser smsd -1 -1 /var/spool/sms sms
> -}
> -
>  src_unpack() {
>  	unpack ${A}
>  	cd "${S}"
> @@ -35,7 +30,12 @@
>  
>  src_compile() {
>  	cd src
> -	emake || die "emake failed"
> +	emake CC="$(tc-getCC)" || die "emake failed"
> +}
> +
> +pkg_preinst() {
> +	enewgroup sms
> +	enewuser smsd -1 -1 /var/spool/sms sms
>  }
>  
>  src_install() {
        chown -R smsd:sms "${D}"/var/spool/sms
        chmod g+s "${D}"/var/spool/sms/incoming

        newinitd "${FILESDIR}"/smsd.initd smsd
        insopts -o smsd -g sms -m0644
> @@ -60,5 +60,6 @@
>  }
>  
>  pkg_postinst() {
> +	touch /var/log/smsd.log
>  	chown -f smsd:sms /var/log/smsd.log
>  }

Remember pkg_preinst is called after src_install.
So the user and group probably don't exist during src_install.

BTW: ROOT should be respected in pkg_postinst too.