From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KuEUr-0001Xb-0V for garchives@archives.gentoo.org; Sun, 26 Oct 2008 22:54:10 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D5FB6E0401; Sun, 26 Oct 2008 22:53:43 +0000 (UTC) Received: from coco.kroah.org (kroah.org [198.145.64.141]) by pigeon.gentoo.org (Postfix) with ESMTP id B242BE0401 for ; Sun, 26 Oct 2008 22:53:43 +0000 (UTC) Received: from localhost (mail.kroah.net [66.93.40.174]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id EEBB448D15; Sun, 26 Oct 2008 15:53:41 -0700 (PDT) Date: Sun, 26 Oct 2008 15:51:11 -0700 From: Greg KH To: Thomas Anderson Cc: Greg KH , gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/bti: bti-007.ebuild ChangeLog metadata.xml Manifest Message-ID: <20081026225111.GB21648@kroah.com> References: <20081026173629.GA4330@spoc> <20081026215802.GA21085@kroah.com> <20081026222913.GB12527@spoc> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081026222913.GB12527@spoc> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 7894baab-2bed-4149-bc09-684638aa5796 X-Archives-Hash: 7f06228efecfac5a2ae5edaf9166d36b On Sun, Oct 26, 2008 at 06:29:13PM -0400, Thomas Anderson wrote: > On Sun, Oct 26, 2008 at 02:58:02PM -0700, Greg KH wrote: > > On Sun, Oct 26, 2008 at 01:36:29PM -0400, Thomas Anderson wrote: > > > On Sun, Oct 26, 2008 at 05:22:26PM +0000, Greg Kroah-Hartman (gregkh) wrote: > > > > src_install() { > > > > doman bti.1 > > > > dobin bti > > > > dodoc bti.example README RELEASE-NOTES > > > > } > > > You really should have some or all of these functions die on failure. > > > > Why would any of these fail if the src_compile succeeded? > "Succeeded" and "Not error out" are different. Src_compile could not > error out but still not produce the executables/produce an executable > with a different name. Either way you end up with a broken installation > of bti. > > And, for some reason I thought that the default was that if there was an > > error in them, they would "die" on their own. Is that not the case? > No, they don't die on their own. As far as I know, very few ebuild > functions do. Econf does, and epatch does as well. I'll look into > writing up a list of which functions die and which don't though, for > convenience. Ok, thanks for the information, I appreciate it. greg k-h