From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KuEUR-0001X5-37 for garchives@archives.gentoo.org; Sun, 26 Oct 2008 22:53:43 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CC9B4E03ED; Sun, 26 Oct 2008 22:53:42 +0000 (UTC) Received: from coco.kroah.org (kroah.org [198.145.64.141]) by pigeon.gentoo.org (Postfix) with ESMTP id A89FEE03ED for ; Sun, 26 Oct 2008 22:53:42 +0000 (UTC) Received: from localhost (mail.kroah.net [66.93.40.174]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id 7E22D48D14; Sun, 26 Oct 2008 15:53:40 -0700 (PDT) Date: Sun, 26 Oct 2008 15:50:23 -0700 From: Greg KH To: Thomas Sachau Cc: gregkh@gentoo.org, gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/bti: bti-007.ebuild ChangeLog metadata.xml Manifest Message-ID: <20081026225023.GA21648@kroah.com> References: <20081026173629.GA4330@spoc> <20081026215802.GA21085@kroah.com> <4904EC6A.5070303@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4904EC6A.5070303@gentoo.org> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: d35f2dfe-20a5-467b-8ce2-3b733a66f5a7 X-Archives-Hash: 02f7b3c7214ffadbad6f9343c38e1359 On Sun, Oct 26, 2008 at 11:17:14PM +0100, Thomas Sachau wrote: > Greg KH schrieb: > >>> src_install() { > >>> doman bti.1 > >>> dobin bti > >>> dodoc bti.example README RELEASE-NOTES > >>> } > >> You really should have some or all of these functions die on failure. > > > > Why would any of these fail if the src_compile succeeded? > > What happens, if upstream changes the name of the binary on version > bump or changes the compile output location? Then I will go and swat upstream upside the head for not realizing that he also needed to fix the ebuild when he bumbed the version :) (hint, upstream and me are the same...) thanks, greg k-h