From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KuE6n-0007u2-Pw for garchives@archives.gentoo.org; Sun, 26 Oct 2008 22:29:18 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 77388E033F; Sun, 26 Oct 2008 22:29:17 +0000 (UTC) Received: from qw-out-1920.google.com (qw-out-1920.google.com [74.125.92.145]) by pigeon.gentoo.org (Postfix) with ESMTP id 53661E033F for ; Sun, 26 Oct 2008 22:29:17 +0000 (UTC) Received: by qw-out-1920.google.com with SMTP id 5so727930qwc.10 for ; Sun, 26 Oct 2008 15:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:cc :subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent:sender; bh=IeOpcpmoyIaBvTs5D/XUNg5Ws0H+UKeTyBZ2q724Nqc=; b=aXcCy6vLKOs852ozVYTzGeKe3QN2ooO2qYSrzCCDeRIWjDO8Syc8j0a0AaafaG7U6X 1Db0WKc3k1aGha+0DESBP0i0Nnhbg4H+2orbeSJSOhANF0Q+9YgA1SdzS3RUbZ7CUntM deyIwG5uK2vFFXaejfYBxsfJBYvURVXhCoE5I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent:sender; b=S3p4a76X0aJ1ijSVK4W/zB2wNWNk7zod9k1JxUdY/WjJCwC2d5BqOAHBxRsNRRsXKH sOuK8/hhAm/DC32pkYNpNujnqOAMZnkdzeDvfH6C7cwJLBrnpcR1tre2HcrjfzDSDttT iAVzi6Y5nPFHMIYpbqrlIx/0XVOutLCXJZWHQ= Received: by 10.215.41.10 with SMTP id t10mr3993865qaj.62.1225060155951; Sun, 26 Oct 2008 15:29:15 -0700 (PDT) Received: from smtp.gmail.com (c-69-249-154-72.hsd1.nj.comcast.net [69.249.154.72]) by mx.google.com with ESMTPS id 34sm7215290yxl.8.2008.10.26.15.29.14 (version=SSLv3 cipher=RC4-MD5); Sun, 26 Oct 2008 15:29:15 -0700 (PDT) Received: by smtp.gmail.com (nbSMTP-1.00) for uid 1001 (using TLSv1/SSLv3 with cipher RC4-MD5 (128/128 bits)) gentoofan23@gentoo.org; Sun, 26 Oct 2008 18:29:14 -0400 (EDT) Date: Sun, 26 Oct 2008 18:29:13 -0400 From: Thomas Anderson To: Greg KH Cc: Thomas Anderson , gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/bti: bti-007.ebuild ChangeLog metadata.xml Manifest Message-ID: <20081026222913.GB12527@spoc> References: <20081026173629.GA4330@spoc> <20081026215802.GA21085@kroah.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XWOWbaMNXpFDWE00" Content-Disposition: inline In-Reply-To: <20081026215802.GA21085@kroah.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: Thomas Anderson X-Archives-Salt: a9803127-e0a3-4620-b8ce-6813ad599bfa X-Archives-Hash: 45e8093dedcafc0b00b2cd6bd90a9e0c --XWOWbaMNXpFDWE00 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 26, 2008 at 02:58:02PM -0700, Greg KH wrote: > On Sun, Oct 26, 2008 at 01:36:29PM -0400, Thomas Anderson wrote: > > On Sun, Oct 26, 2008 at 05:22:26PM +0000, Greg Kroah-Hartman (gregkh) w= rote: > > > src_install() { > > > doman bti.1 > > > dobin bti > > > dodoc bti.example README RELEASE-NOTES > > > } > > You really should have some or all of these functions die on failure. >=20 > Why would any of these fail if the src_compile succeeded? "Succeeded" and "Not error out" are different. Src_compile could not error out but still not produce the executables/produce an executable with a different name. Either way you end up with a broken installation of bti. > And, for some reason I thought that the default was that if there was an > error in them, they would "die" on their own. Is that not the case? No, they don't die on their own. As far as I know, very few ebuild functions do. Econf does, and epatch does as well. I'll look into writing up a list of which functions die and which don't though, for convenience. --XWOWbaMNXpFDWE00 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkkE7zkACgkQF6yMcaBxwHn15QCgg9xRobKQHXK0C/YXqzyffs3C NHsAnAxCSiTWKSJBFxeCw4X4Q8WNz4oO =fKP+ -----END PGP SIGNATURE----- --XWOWbaMNXpFDWE00--