[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/bti: bti-007.ebuild ChangeLog metadata.xml Manifest

[Thomas Anderson <gentoofan23@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]

On Sun, Oct 26, 2008 at 02:58:02PM -0700, Greg KH wrote:
> On Sun, Oct 26, 2008 at 01:36:29PM -0400, Thomas Anderson wrote:
> > On Sun, Oct 26, 2008 at 05:22:26PM +0000, Greg Kroah-Hartman (gregkh) wrote:
> > > src_install() {
> > > 	doman bti.1
> > > 	dobin bti
> > > 	dodoc bti.example README RELEASE-NOTES
> > > }
> > You really should have some or all of these functions die on failure.
> 
> Why would any of these fail if the src_compile succeeded?
"Succeeded" and "Not error out" are different. Src_compile could not
error out but still not produce the executables/produce an executable
with a different name. Either way you end up with a broken installation
of bti.
> And, for some reason I thought that the default was that if there was an
> error in them, they would "die" on their own.  Is that not the case?
No, they don't die on their own. As far as I know, very few ebuild
functions do. Econf does, and epatch does as well. I'll look into
writing up a list of which functions die and which don't though, for
convenience.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]