From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KuDfE-0005HE-4v for garchives@archives.gentoo.org; Sun, 26 Oct 2008 22:00:48 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 02B13E038E; Sun, 26 Oct 2008 22:00:48 +0000 (UTC) Received: from coco.kroah.org (kroah.org [198.145.64.141]) by pigeon.gentoo.org (Postfix) with ESMTP id DBDA6E038E for ; Sun, 26 Oct 2008 22:00:47 +0000 (UTC) Received: from localhost (mail.kroah.net [66.93.40.174]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by coco.kroah.org (Postfix) with ESMTPSA id C4EB548D14; Sun, 26 Oct 2008 15:00:45 -0700 (PDT) Date: Sun, 26 Oct 2008 14:58:02 -0700 From: Greg KH To: Thomas Anderson Cc: gentoo-dev@lists.gentoo.org, gregkh@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/bti: bti-007.ebuild ChangeLog metadata.xml Manifest Message-ID: <20081026215802.GA21085@kroah.com> References: <20081026173629.GA4330@spoc> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081026173629.GA4330@spoc> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: e2fc6efe-a16d-44f0-bd12-8742d5a85781 X-Archives-Hash: 25186de94a765e8f44b595cd2908d83f On Sun, Oct 26, 2008 at 01:36:29PM -0400, Thomas Anderson wrote: > On Sun, Oct 26, 2008 at 05:22:26PM +0000, Greg Kroah-Hartman (gregkh) wrote: > > # Copyright 1999-2008 Gentoo Foundation > > # Distributed under the terms of the GNU General Public License v2 > > # $Header: /var/cvsroot/gentoo-x86/net-misc/bti/bti-007.ebuild,v 1.1 2008/10/26 17:22:26 gregkh Exp $ > > > > RDEPEND="${DEPEND}" > > > > src_compile() { > > emake || die "emake failed" > > } > This is the default src_compile. Ah, thanks, I should just drop this then. > > src_install() { > > doman bti.1 > > dobin bti > > dodoc bti.example README RELEASE-NOTES > > } > You really should have some or all of these functions die on failure. Why would any of these fail if the src_compile succeeded? And, for some reason I thought that the default was that if there was an error in them, they would "die" on their own. Is that not the case? > Since that's all the ebuild installs, the package is completely > nonfunctional if bti is not installed(I'd die on all three but you don't > have to die on the last one). Might as well be consistent :) thanks for the review, greg k-h