From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Ku9XV-0003mD-Sc for garchives@archives.gentoo.org; Sun, 26 Oct 2008 17:36:34 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id CB38FE0350; Sun, 26 Oct 2008 17:36:32 +0000 (UTC) Received: from qw-out-1920.google.com (qw-out-1920.google.com [74.125.92.144]) by pigeon.gentoo.org (Postfix) with ESMTP id A61E8E0350 for ; Sun, 26 Oct 2008 17:36:32 +0000 (UTC) Received: by qw-out-1920.google.com with SMTP id 5so693696qwc.10 for ; Sun, 26 Oct 2008 10:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:date:from:to:subject :message-id:references:mime-version:content-type:content-disposition :in-reply-to:user-agent:sender; bh=kAkQj4E+I2QZrvb4GDrmojESsRKd0tZ24zLTqoBL6jg=; b=FWeg2m11plI94Gv+jNYvUKZvcDxaIW3dg2UIHNsph/VjmtdzQfpWcZirmqVDHGw/Jb 6oE3j2zSVaDoq8PTi8sMalaInuxoIDHKHQRPsNF44pol8GfK2+9dcqvAZvJYyIfuJ1KR U27p+ttFqXYTW/cQJduPNUqnoCf5VeHvXpCMc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent:sender; b=b9dYSrhYT94L7nyK1i5hokHJVq1l8WzCd6IjUUBQxL6dIjLqsEScuDpcA44H7xu6iC MHU3qfsyME0J/aMzRxh6aQQUJemLisGTEOsazEDCPKHpZqt0N2bHWs/mIsRwlxsqDc1O 4X3gE+UtEnTlKaOqsJLUtQzx0geSmxIi+AqbQ= Received: by 10.214.115.4 with SMTP id n4mr1641225qac.341.1225042591283; Sun, 26 Oct 2008 10:36:31 -0700 (PDT) Received: from smtp.gmail.com (c-69-249-154-72.hsd1.nj.comcast.net [69.249.154.72]) by mx.google.com with ESMTPS id 6sm2679687ywn.0.2008.10.26.10.36.30 (version=SSLv3 cipher=RC4-MD5); Sun, 26 Oct 2008 10:36:30 -0700 (PDT) Received: by smtp.gmail.com (nbSMTP-1.00) for uid 1001 (using TLSv1/SSLv3 with cipher RC4-MD5 (128/128 bits)) gentoofan23@gentoo.org; Sun, 26 Oct 2008 13:36:30 -0400 (EDT) Date: Sun, 26 Oct 2008 13:36:29 -0400 From: Thomas Anderson To: gentoo-dev@lists.gentoo.org, gregkh@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/bti: bti-007.ebuild ChangeLog metadata.xml Manifest Message-ID: <20081026173629.GA4330@spoc> References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: Thomas Anderson X-Archives-Salt: f052ca7f-6d2b-4e35-8c96-fbd02f4673e9 X-Archives-Hash: a158e182582121f5df4708fdf3516eb9 --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 26, 2008 at 05:22:26PM +0000, Greg Kroah-Hartman (gregkh) wrote: > # Copyright 1999-2008 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Header: /var/cvsroot/gentoo-x86/net-misc/bti/bti-007.ebuild,v 1.1 2008= /10/26 17:22:26 gregkh Exp $ >=20 > RDEPEND=3D"${DEPEND}" >=20 > src_compile() { > emake || die "emake failed" > } This is the default src_compile. >=20 > src_install() { > doman bti.1 > dobin bti > dodoc bti.example README RELEASE-NOTES > } You really should have some or all of these functions die on failure. Since that's all the ebuild installs, the package is completely nonfunctional if bti is not installed(I'd die on all three but you don't have to die on the last one). --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkkEqp0ACgkQF6yMcaBxwHlDEwCfdIKHDVz5oSAEvJaQ/ill/XMt IloAn0xCJ8X1nVen/gkwTC9WBQ7182a0 =eaP6 -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62--