From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Kqanj-0000Fk-QM for garchives@archives.gentoo.org; Thu, 16 Oct 2008 21:54:36 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 10287E0367; Thu, 16 Oct 2008 21:54:34 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id DCF71E0367 for ; Thu, 16 Oct 2008 21:54:33 +0000 (UTC) Received: from gentoo.org (xray.science.oregonstate.edu [128.193.220.51]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 7B20B64D81 for ; Thu, 16 Oct 2008 21:54:32 +0000 (UTC) Date: Thu, 16 Oct 2008 14:54:32 -0700 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] virtualx eclass Message-ID: <20081016215432.GA15437@comet> References: <48F74557.30906@gentoo.org> <48F75F30.7030408@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Content-Disposition: inline In-Reply-To: <48F75F30.7030408@gentoo.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-Archives-Salt: 93bb1d11-495f-4c1c-b0ce-605412d0c569 X-Archives-Hash: d5750ae73cfbb1acb0b40fd5444b2d1b --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 11:35 Thu 16 Oct , Doug Goldstein wrote: > Doug Goldstein wrote: > > While the rule of thumb has been if an eclass needs something it should > > provide it's own depends. However the virtualx eclass needs to be > > different simply because in some cases it's only uses for tests (this is > > it's most common usage in the whole) tree. When it's used for tests > > pulling in the xorg-server the most ideal situation would be if > > xorg-server was only pulled in on USE=3Dtest because currently for anyo= ne > > emerging an app that uses GTK+ they have a weird situation in the fact > > that all of GTK+'s depends that have USE=3DX use it to mean libX11 (as = do > > most usages of the X USE flag), however GTK+ itself due to it's usage of > > the virtualx eclass pulls in xorg-server when USE=3DX, which is only us= ed > > for tests. This results in a confusing experience for users looking to > > built a headless machine. > > > > It'd be a lot more consistent if ebuilds provided a USE flag or directly > > depended on the xorg-server and then used the functions in the eclass. > > So in summary, those are the changes I plan on making very shortly. If > > someone's got some input, please speak up. > > > > =20 > Alright... after talking to Diego, Dave, and Remi the final result that > I've come up with is the following: >=20 > VIRTUALX_CONDITIONAL_USE=3D"test" >=20 > inherit virtualx >=20 > That'll result in virtualx adding the following: >=20 > DEPEND=3D"test? ( x11-base/xorg-server x11-apps/xhost )" >=20 > if VIRTUALX_CONDITIONAL_USE is unset (as it will be for all ebuilds > initially) the default will be "X". Which means the default is the same > as what we've got today. If it's set to an empty string, it'll always be > required. Otherwise, it will use the supplied USE flag. I'm not sure whether this would work, but one idea would be to handle=20 dependencies depending on what's in IUSE of the ebuild inheriting. --=20 Thanks, Donnie Donnie Berkholz Developer, Gentoo Linux Blog: http://dberkholz.wordpress.com --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkj3uBgACgkQXVaO67S1rtsJZQCgogY6DV/u5O9NaTrufhFVl0hi cRoAn0836tI9m1t+q8d6Cnj8fEXQvzwE =rn/3 -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--