From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KmUOc-0007zG-Hk for garchives@archives.gentoo.org; Sun, 05 Oct 2008 14:15:42 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2CD8DE04EC; Sun, 5 Oct 2008 14:15:41 +0000 (UTC) Received: from mail.goodpoint.de (tori.goodpoint.de [85.10.203.41]) by pigeon.gentoo.org (Postfix) with ESMTP id D7595E04EC for ; Sun, 5 Oct 2008 14:15:40 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rbu) by mail.goodpoint.de (Postfix) with ESMTP id 0D72B108395 for ; Sun, 5 Oct 2008 16:15:39 +0200 (CEST) From: Robert Buchholz To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI Date: Sun, 5 Oct 2008 16:15:33 +0200 User-Agent: KMail/1.9.7 References: <48E25C61.7070805@gentoo.org> <18664.32860.348921.385462@a1ihome1.kph.uni-mainz.de> In-Reply-To: <18664.32860.348921.385462@a1ihome1.kph.uni-mainz.de> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1655010.fjr4DzVA1z"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200810051615.37614.rbu@gentoo.org> X-Archives-Salt: 539b9a84-8435-4203-9514-27bb2892d148 X-Archives-Hash: d9ee91602f59915a99dfaf2317c7beeb --nextPart1655010.fjr4DzVA1z Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday, 5. October 2008, Ulrich Mueller wrote: > >>>>> On Tue, 30 Sep 2008, Petteri R=E4ty wrote: > >>> > >>> dodoc ${DOCS} || die "dodoc failed" > >> > >> This seems alright fine to me > > > > It's not. If you want to have default DOCS then you should loop > > through the items and check with [[ -e ]] before trying to install > > them. > > I'm not convinced that this is a good idea. Then you won't catch cases > where upstream removes or renames files. > > Besides, dodoc already checks for -e by itself (and emits a warning if > the file does not exist). > > So, maybe just do a 'dodoc "${DOCS}"' and omit the die? Then it won't > fail but the warning message would be preserved. I understood Petteri's comment to be related to the default case (i.e. the= =20 else-branch), and I have to agree there: Ebuilds that do not override=20 src_install should not emit a warning when some ChangeLog file is missing=20 that the ebuild never specified to install. Robert --nextPart1655010.fjr4DzVA1z Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iQIVAwUASOjMCSaaHo/OfoM5AQL3pxAAjCETne7mxxJ1o5JE1y9PypI2CGTdVsMl 1SOj4rSYSHIJIbVFRpwetqUT8UqnIEYyW7bdgSu/5xu2EnmkFOPEwgJ7pT+wfl+X gNSW3alLkD9jptfcAsawNIAeWO1frEpDfnInVYh5o9MkCIa2X+5Nshq2o/BR+mZn jF8obo/bFaFCItz1cqzFCrIzYGXsxB5uhTyk6RZ9W+debPR4yij2WZiRmYVKNtwg 2kstCQMWbCbgjj+0NZN+lU2YDNi9Wtl5RROqgSXDfV/sQTzATaRVGpvZY9qc79S3 r8doj7GV4yDVNtbaUwbUOjTUijM7cPFVFRD0TqOi4aOxM9v8KtdrlQdmdToJEeT0 297jpFzv5vPLbThBjsIsENcLFuI8fnIPZ1kSqsm5vfTdv6nva+bQUK0oxh2jnc+N EPxG89U3hK0QsMtkuCqmg+X2S75WJZREFZ7wIRIT9Lziljrgw9E08TrJpKC2V/4w nJ3bPyRqhvWKy6CyZh9K4/jirtg8T7ikd6F/hW4gA1a+iGu018TKrgtsvyqySBU6 nPpxs3NR+IZbZvM8Zvn6uZCStkClDm2ttXy6APBzeflWvMGBy3pvydkKqR5mjyZ0 OvSbkMsF73jn7eOJ8uuaE+2gQZAxWnukvxSQYYkmRgggNZJOdSSftsvRPCnKZGJI ATbxtGb3ccY= =jq1B -----END PGP SIGNATURE----- --nextPart1655010.fjr4DzVA1z--