Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI

[Robert Buchholz <rbu@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

On Sunday, 5. October 2008, Ulrich Mueller wrote:
> >>>>> On Tue, 30 Sep 2008, Petteri Räty wrote:
> >>>
> >>> dodoc ${DOCS} || die "dodoc failed"
> >>
> >> This seems alright fine to me
> >
> > It's not. If you want to have default DOCS then you should loop
> > through the items and check with [[ -e ]] before trying to install
> > them.
>
> I'm not convinced that this is a good idea. Then you won't catch cases
> where upstream removes or renames files.
>
> Besides, dodoc already checks for -e by itself (and emits a warning if
> the file does not exist).
>
> So, maybe just do a 'dodoc "${DOCS}"' and omit the die? Then it won't
> fail but the warning message would be preserved.

I understood Petteri's comment to be related to the default case (i.e. the 
else-branch), and I have to agree there: Ebuilds that do not override 
src_install should not emit a warning when some ChangeLog file is missing 
that the ebuild never specified to install.

Robert

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]