From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KiILt-00026C-Dz for garchives@archives.gentoo.org; Wed, 24 Sep 2008 00:35:33 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 9AAC5E0779; Wed, 24 Sep 2008 00:35:32 +0000 (UTC) Received: from mail.goodpoint.de (tori.goodpoint.de [85.10.203.41]) by pigeon.gentoo.org (Postfix) with ESMTP id 4BFCEE0779 for ; Wed, 24 Sep 2008 00:35:32 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rbu) by mail.goodpoint.de (Postfix) with ESMTP id D78FF10B40F for ; Wed, 24 Sep 2008 02:35:30 +0200 (CEST) From: Robert Buchholz To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI Date: Wed, 24 Sep 2008 02:35:18 +0200 User-Agent: KMail/1.9.9 References: <18646.45711.173931.589892@a1ihome1.kph.uni-mainz.de> <48D94608.7060805@gentoo.org> In-Reply-To: <48D94608.7060805@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6950201.xjQYMW8KPW"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200809240235.22859.rbu@gentoo.org> X-Archives-Salt: 4f6bafed-17b1-4289-b096-7569202d5a95 X-Archives-Hash: 7797d455c69a484215ddffa7ff02a776 --nextPart6950201.xjQYMW8KPW Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tuesday 23 September 2008, Thomas Sachau wrote: > Ulrich Mueller schrieb: > > And I still don't see why we would need the most general solution > > for a *default* function. There's always the possibility to write > > your own src_install() for the few ebuilds that need it. > > > > Ulrich > > I aggree with Ulrich in this case. This is just a suggestion for a > default src_install funcion, nothing that should cover every possible > case. So if you have some special DOC that does not work with the > default install, you can still do it the normal way. So my suggestion > for a default src_install: > > default_src_install() { > if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then > if emake DESTDIR=3D"${D} install || einstall ; then > die "install failed" > else > if [[ -n ${DOCS} ]]; then > dodoc ${DOCS} || die "dodoc failed" > fi > fi > fi > } > > Any more comments? Good? Bad? Interested? Let's go with an even simpler default implementation: default_src_install() { if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then emake DESTDIR=3D"${D}" install || die "emake install failed" =A0=A0=A0=A0=A0=A0=A0=A0fi if [ -n "${DOCS}" ]; then dodoc ${DOCS} || die "dodoc failed" fi } It addresses the following issues: * Do not run einstall if emake fails * Run dodoc even if no Makefile is present, this might come in handy for ebuilds calling default() * die dodoc failure case * hopefully fix the flaws (not really) pointed out by zlin Robert --nextPart6950201.xjQYMW8KPW Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJI2YtKAAoJECaaHo/OfoM5HzIP/2OwBRW+95V4HcE4Z5z8enSY FHmkQTsyVBUdesCsN4Uh2rK21jU6qHRppSlcfxfGc4gPEGpzJPMB6SxwEKm1R/MC r5OHQB98D4ZLx2fkDG5lkFQao5jpQh/uK10V1Y7a9eoKBJEoseu6eA+nw08rR2L8 qETcqPpiDebktfPalMGT4XQrDezWcSlwcWyE1yCbRIOXt5B0LjN6GS1ORsYukHVM jG5zgj/v0z1qNY6FxucGSUmUkGxeb1OZWIWKb+WjgNnSyECkZoPIdPollexhJltd IRiiglhWLCg/KaMDSykYF1QLUKdfsLQjled3CFKRVLtSovq3Ikdm6EMEGx2oLJsy x8WdluW5IgBrmVKoGcXb1Flz3Ho8mCSS1Kz6ffjpMtHy6/ErcXtfRgdCgn3JbFP3 9Pw/0JdNtVipMBeFHC0GqL49EeSbc1EjMTCMEblWnW+NWx8bOmWNdP2lhaHOMCHr xzooD/IzSt/Ag7310PUK3RCBO5yAWqBapuh6URJ1tJ0rq582d1fbo747l1K6APSr QxMwxQpJsOXY/XMIQB12tbh9aCZDUKwOOqTvmeDeoNdACSgD5NIw7OqaFTWP5GOz xzhJV1F6X3XDUNfHRp9qjLHIbdD0pkZiUfhhK+8TB1xSEELjGsbZN3zlo9pzwToy RrJfgUhwnST/O/xyPCoW =VW6E -----END PGP SIGNATURE----- --nextPart6950201.xjQYMW8KPW--