From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KhJnJ-0004lq-I7 for garchives@archives.gentoo.org; Sun, 21 Sep 2008 07:55:49 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 58732E0722; Sun, 21 Sep 2008 07:55:45 +0000 (UTC) Received: from amun.cheops.ods.org (amun.cheops.ods.org [82.95.138.191]) by pigeon.gentoo.org (Postfix) with ESMTP id 2FA54E0722 for ; Sun, 21 Sep 2008 07:55:45 +0000 (UTC) Received: from tefnut.cheops.ods.org ([2001:888:1022:0:211:24ff:fe37:e46e] helo=gentoo.org) by amun.cheops.ods.org with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1KhJnC-0002C6-Nn for gentoo-dev@lists.gentoo.org; Sun, 21 Sep 2008 09:55:43 +0200 Date: Sun, 21 Sep 2008 09:55:38 +0200 From: Fabian Groffen To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI Message-ID: <20080921075538.GB3785@gentoo.org> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20080916000101.GJ6035@curie-int.orbis-terrarum.net> <48D4DEF8.10202@gentoo.org> <48D54A08.7050603@gentoo.org> <48D599AD.20605@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <48D599AD.20605@gentoo.org> User-Agent: Mutt/1.5.18 (Darwin 8.11.0, VIM - Vi IMproved 7.2) Organization: Gentoo Foundation, Inc. X-Content-Scanned: by amun.cheops.ods.org (Exim Exiscan) using SpamAssassin and ClamAV X-Archives-Salt: 8954ea88-f907-4c63-8e35-b5edb0841a93 X-Archives-Hash: 7e88a7461a59a2fec2ffb6dc1216c76e On 21-09-2008 02:47:41 +0200, Thomas Sachau wrote: > updated version: > if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then > emake DESTDIR="${D}" install || einstall > if [[ $?>0 ]]; then Please either use POSIX or bash, mixing them looks so ugly and pointless to me. Apart from that I don't think calling einstall when emake install fails makes sense. Ideally einstall should never be used IMO. -- Fabian Groffen Gentoo on a different level