public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Fabian Groffen <grobian@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI
Date: Sun, 21 Sep 2008 09:55:38 +0200	[thread overview]
Message-ID: <20080921075538.GB3785@gentoo.org> (raw)
In-Reply-To: <48D599AD.20605@gentoo.org>

On 21-09-2008 02:47:41 +0200, Thomas Sachau wrote:
> updated version:

> 	if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
> 		emake DESTDIR="${D}" install || einstall
> 		if [[ $?>0 ]]; then

Please either use POSIX or bash, mixing them looks so ugly and pointless
to me.

Apart from that I don't think calling einstall when emake install fails
makes sense.  Ideally einstall should never be used IMO.


-- 
Fabian Groffen
Gentoo on a different level



  reply	other threads:[~2008-09-21  7:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-16  0:01 [gentoo-dev] Bugzilla3 and Bugzilla Survey 2008 Robin H. Johnson
2008-09-20 11:31 ` [gentoo-dev] Default src_install for EAPI-2 or following EAPI Thomas Sachau
2008-09-20 12:12   ` [gentoo-dev] " Steve Long
2008-09-20 19:07   ` [gentoo-dev] " Petteri Räty
2008-09-21  0:47     ` Thomas Sachau
2008-09-21  7:55       ` Fabian Groffen [this message]
     [not found] <bcwiO-7zO-1@gated-at.bofh.it>
2008-09-21 20:46 ` [gentoo-dev] " Ulrich Mueller
2008-09-23 19:39   ` Thomas Sachau
2008-09-23 23:21     ` Bo Ørsted Andresen
2008-09-24  7:46       ` Nirbheek Chauhan
2008-09-27 10:17         ` Thomas Sachau
2008-09-29  5:16           ` Nirbheek Chauhan
2008-09-30 17:05             ` Petteri Räty
2008-10-05  8:52               ` [gentoo-dev] " Ulrich Mueller
2008-10-05 14:15                 ` Robert Buchholz
2008-10-05 15:45                   ` Ulrich Mueller
2008-10-05 16:47                     ` Robert Buchholz
2008-10-05 17:03                       ` Ulrich Mueller
2008-10-05 17:58                       ` Thomas Sachau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080921075538.GB3785@gentoo.org \
    --to=grobian@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox