* [gentoo-dev] Bugzilla3 and Bugzilla Survey 2008
@ 2008-09-16 0:01 Robin H. Johnson
2008-09-20 11:31 ` [gentoo-dev] Default src_install for EAPI-2 or following EAPI Thomas Sachau
0 siblings, 1 reply; 6+ messages in thread
From: Robin H. Johnson @ 2008-09-16 0:01 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
For those asking about Bugzilla3 for Gentoo, it's a work-in-progress for
the test version. Hopefully I'll announce testing access in the next
week or two.
On a side note, upstream Bugzilla was doing a survey on large Bugzilla
installs, and contacted me to get the Gentoo perspective. The results
are up now: https://wiki.mozilla.org/Bugzilla:Survey
--
Robin Hugh Johnson
Gentoo Linux Developer & Infra Guy
E-Mail : robbat2@gentoo.org
GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
[-- Attachment #2: Type: application/pgp-signature, Size: 329 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [gentoo-dev] Default src_install for EAPI-2 or following EAPI
2008-09-16 0:01 [gentoo-dev] Bugzilla3 and Bugzilla Survey 2008 Robin H. Johnson
@ 2008-09-20 11:31 ` Thomas Sachau
2008-09-20 12:12 ` [gentoo-dev] " Steve Long
2008-09-20 19:07 ` [gentoo-dev] " Petteri Räty
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Sachau @ 2008-09-20 11:31 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
I see, we have a default src_unpack and a default src_compile but a default src_install is still
missing. Here is my suggestion (taken and modified from bug 33544):
src_install() {
if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
emake DESTDIR=${D} install || die "emake install failed"
[[ -n ${DOCS} ]] && dodoc ${DOCS}
else
einstall || die "einstall failed"
[[ -n ${DOCS} ]] && dodoc ${DOCS}
fi
}
Any comments?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 315 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [gentoo-dev] Re: Default src_install for EAPI-2 or following EAPI
2008-09-20 11:31 ` [gentoo-dev] Default src_install for EAPI-2 or following EAPI Thomas Sachau
@ 2008-09-20 12:12 ` Steve Long
2008-09-20 19:07 ` [gentoo-dev] " Petteri Räty
1 sibling, 0 replies; 6+ messages in thread
From: Steve Long @ 2008-09-20 12:12 UTC (permalink / raw
To: gentoo-dev
Thomas Sachau wrote:
> I see, we have a default src_unpack and a default src_compile but a
> default src_install is still missing. Here is my suggestion (taken and
> modified from bug 33544):
>
> src_install() {
> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
> emake DESTDIR=${D} install || die "emake install failed"
You need to quote $D there, eg: DESTDIR="$D" as it's a parameter to a
command there, not a temporary export (as: DESTDIR=$D emake.. would be.)
> [[ -n ${DOCS} ]] && dodoc ${DOCS}
> else
> einstall || die "einstall failed"
> [[ -n ${DOCS} ]] && dodoc ${DOCS}
> fi
> }
>
> Any comments?
It might be wise to use an array for DOCS there, so that filenames with
spaces are dealt with correctly. (I'm thinking of all those lovely GUI
apps.)
To keep compatibility with space-separated values, I use this function:
isArr() [[ $(declare -p "$1" 2>/dev/null) = 'declare -a'* ]]
(Yes I know, it's fugly.)
So this kinda logic deals with both:
if isArr DOCS; then
((${#DOCS[@]})) && dodoc "${DOCS[@]}"
else [[ $DOCS ]] && dodoc $DOCS
fi
(There's no need to repeat it, just move it to after the previous if.)
That can easily be initialised with a glob, eg DOCS=("$S"/doc/*) (although I
recommend nullglob if doing so.)
[See http://wooledge.org:8000/BashFAQ/073 (half way down) if you need to
strip prefixes or the like.]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI
2008-09-20 11:31 ` [gentoo-dev] Default src_install for EAPI-2 or following EAPI Thomas Sachau
2008-09-20 12:12 ` [gentoo-dev] " Steve Long
@ 2008-09-20 19:07 ` Petteri Räty
2008-09-21 0:47 ` Thomas Sachau
1 sibling, 1 reply; 6+ messages in thread
From: Petteri Räty @ 2008-09-20 19:07 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
Thomas Sachau kirjoitti:
> I see, we have a default src_unpack and a default src_compile but a default src_install is still
> missing. Here is my suggestion (taken and modified from bug 33544):
>
> src_install() {
> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
> emake DESTDIR=${D} install || die "emake install failed"
> [[ -n ${DOCS} ]] && dodoc ${DOCS}
> else
> einstall || die "einstall failed"
> [[ -n ${DOCS} ]] && dodoc ${DOCS}
> fi
> }
>
> Any comments?
>
einstall uses make so doesn't really make sense.
Regards,
Petteri
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI
2008-09-20 19:07 ` [gentoo-dev] " Petteri Räty
@ 2008-09-21 0:47 ` Thomas Sachau
2008-09-21 7:55 ` Fabian Groffen
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Sachau @ 2008-09-21 0:47 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 964 bytes --]
Petteri Räty schrieb:
> Thomas Sachau kirjoitti:
>> I see, we have a default src_unpack and a default src_compile but a
>> default src_install is still
>> missing. Here is my suggestion (taken and modified from bug 33544):
>>
>> src_install() {
>> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
>> emake DESTDIR=${D} install || die "emake install failed"
>> [[ -n ${DOCS} ]] && dodoc ${DOCS}
>> else
>> einstall || die "einstall failed"
>> [[ -n ${DOCS} ]] && dodoc ${DOCS}
>> fi
>> }
>>
>> Any comments?
>>
>
> einstall uses make so doesn't really make sense.
>
> Regards,
> Petteri
>
updated version:
src_install() {
if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
emake DESTDIR="${D}" install || einstall
if [[ $?>0 ]]; then
die "install failed"
else
if [[ -n ${DOCS} ]]; then
dodoc ${DOCS} || die "dodoc failed"
fi
fi
fi
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 315 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] Default src_install for EAPI-2 or following EAPI
2008-09-21 0:47 ` Thomas Sachau
@ 2008-09-21 7:55 ` Fabian Groffen
0 siblings, 0 replies; 6+ messages in thread
From: Fabian Groffen @ 2008-09-21 7:55 UTC (permalink / raw
To: gentoo-dev
On 21-09-2008 02:47:41 +0200, Thomas Sachau wrote:
> updated version:
> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
> emake DESTDIR="${D}" install || einstall
> if [[ $?>0 ]]; then
Please either use POSIX or bash, mixing them looks so ugly and pointless
to me.
Apart from that I don't think calling einstall when emake install fails
makes sense. Ideally einstall should never be used IMO.
--
Fabian Groffen
Gentoo on a different level
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-09-21 7:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-16 0:01 [gentoo-dev] Bugzilla3 and Bugzilla Survey 2008 Robin H. Johnson
2008-09-20 11:31 ` [gentoo-dev] Default src_install for EAPI-2 or following EAPI Thomas Sachau
2008-09-20 12:12 ` [gentoo-dev] " Steve Long
2008-09-20 19:07 ` [gentoo-dev] " Petteri Räty
2008-09-21 0:47 ` Thomas Sachau
2008-09-21 7:55 ` Fabian Groffen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox