[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/hylafax: ChangeLog hylafax-4.4.4.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/hylafax: ChangeLog hylafax-4.4.4.ebuild

[Donnie Berkholz]

[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]

On 23:05 Sun 13 Jul     , Steve Arnold (nerdboy) wrote:
> 1.1                  net-misc/hylafax/hylafax-4.4.4.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/hylafax/hylafax-4.4.4.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-misc/hylafax/hylafax-4.4.4.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	# gcc standard C++ header changes
> 	if [ $(gcc-major-version) -eq 4 ] && [ $(gcc-minor-version) -ge 3 ] ; then
> 	    sed -i -e 's:"new.h":<new>:g' configure util/Types.h || die "sed failed"
> 	    sed -i -e 's:"iostream.h":<iostream>\n using namespace std;:g' \
> 		configure || die "sed failed"
> 	fi

Has a patch been sent upstream for this?

> 	if use html; then
> 		my_conf="${my_conf} --with-HTML=yes"
> 	else
> 		my_conf="${my_conf} --with-HTML=no"
> 	fi

Does this work?

  my_conf="${my_conf} $(use_with html HTML)"

> 	#--enable-pam isn't valid
> 	use pam || my_conf="${my_conf} $(use_enable pam)"

Might avoid some confusion with just --disable-pam since --enable 
doesn't work.

> 	# eval required for quoting in ${my_conf} to work properly, better way?
> 	eval ./configure --nointeractive ${my_conf} || die "./configure failed"

That's kinda gross. What exactly is the problem?

> 	emake -j1 || die "emake failed"

Have you filed an upstream bug about parallel build being broken?

> 	generate_files # in this case, it only generates the env.d entry
> 
> 	einfo "Adding env.d entry for Hylafax"
> 	doenvd 99${P}

doenvd doesn't die on failure.

> 	einfo "Adding init.d entry for Hylafax"
> 	newinitd "${FILESDIR}"/${PN}-4.2 ${PN}

Neither does newinitd.

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]