From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Jv3qm-0005Oq-69 for garchives@archives.gentoo.org; Sun, 11 May 2008 05:11:56 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EF0E3E0352; Sun, 11 May 2008 05:11:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by pigeon.gentoo.org (Postfix) with ESMTP id D8337E0352 for ; Sun, 11 May 2008 05:11:53 +0000 (UTC) Received: from dsl093-040-174.pdx1.dsl.speakeasy.net ([66.93.40.174] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.68 #1 (Red Hat Linux)) id 1Jv3qh-0004sY-Uv; Sun, 11 May 2008 05:11:52 +0000 Date: Sat, 10 May 2008 22:05:37 -0700 From: Greg KH To: Christian Faulhammer Cc: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/moreutils: moreutils-0.29.ebuild ChangeLog Manifest Message-ID: <20080511050537.GA8817@kroah.com> References: <20080510095024.6ca6676c@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080510095024.6ca6676c@gentoo.org> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: f781625d-822b-4d1c-b5ed-4c0373f1a0e8 X-Archives-Hash: f78e19ebcace0c190a8ae340a43e7349 On Sat, May 10, 2008 at 09:50:24AM +0200, Christian Faulhammer wrote: > "Greg Kroah-Hartman (gregkh)" : > > > Added: moreutils-0.29.ebuild ChangeLog Manifest > > Log: > > initial ebuild for the moreutils package > > src_unpack() { > > unpack ${A} > > cd "${WORKDIR}/moreutils" > > epatch "${FILESDIR}/docbook-makefile.patch" > > } > > > > src_compile() { > > cd "${WORKDIR}/moreutils" > > emake CFLAGS="${CFLAGS}" || die "emake failed" > > } > > > > src_install() { > > cd "${WORKDIR}/moreutils" > > emake PREFIX="${D}" install || die "install failed" > > } > > > Wouldn't it be easier to set S=${WORKDIR}/${PN} instead of cd'ing > three times worthlessly? The line before epatch is necessary though. Didn't realize I could override that, I'll consider it if I can't convince upstream to put the version number in the directory name :) thanks, greg k-h -- gentoo-dev@lists.gentoo.org mailing list