From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Jujqn-00055X-AW for garchives@archives.gentoo.org; Sat, 10 May 2008 07:50:37 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0535CE0361; Sat, 10 May 2008 07:50:35 +0000 (UTC) Received: from mo-p07-ob.rzone.de (mo-p07-ob.rzone.de [81.169.146.188]) by pigeon.gentoo.org (Postfix) with ESMTP id 90D30E0361 for ; Sat, 10 May 2008 07:50:34 +0000 (UTC) X-RZG-CLASS-ID: mo07 X-RZG-AUTH: hXn+rC1arvT7Lf9I/zKDqjrgIkrokD1Qxy5bIq+LzaqNFlYumdVEr+ZU55OFiv1Jsb+WghQYoDRh7g== Received: from localhost (u-7-240.vpn.RWTH-Aachen.DE [137.226.103.240]) by post.webmailer.de (fruni mo41) (RZmta 16.34) with ESMTP id i004a8k4A72n9D ; Sat, 10 May 2008 09:50:29 +0200 (MEST) (envelope-from: ) Date: Sat, 10 May 2008 09:50:24 +0200 From: Christian Faulhammer To: gentoo-dev@lists.gentoo.org, gregkh@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/moreutils: moreutils-0.29.ebuild ChangeLog Manifest Message-ID: <20080510095024.6ca6676c@gentoo.org> In-Reply-To: References: X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.8; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/zsd_OU=775VxhYDkNqcMBKx"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Archives-Salt: cd97517c-2af4-4801-b28b-afe2a82ba22f X-Archives-Hash: 12e894416214903c5d9e0c9a1bb0431a --Sig_/zsd_OU=775VxhYDkNqcMBKx Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable "Greg Kroah-Hartman (gregkh)" : > Added: moreutils-0.29.ebuild ChangeLog Manifest > Log: > initial ebuild for the moreutils package > src_unpack() { > unpack ${A} > cd "${WORKDIR}/moreutils" > epatch "${FILESDIR}/docbook-makefile.patch" > } >=20 > src_compile() { > cd "${WORKDIR}/moreutils" > emake CFLAGS=3D"${CFLAGS}" || die "emake failed" > } >=20 > src_install() { > cd "${WORKDIR}/moreutils" > emake PREFIX=3D"${D}" install || die "install failed" > } Wouldn't it be easier to set S=3D${WORKDIR}/${PN} instead of cd'ing three times worthlessly? The line before epatch is necessary though. V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/zsd_OU=775VxhYDkNqcMBKx Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkglU8AACgkQNQqtfCuFneORJQCfRQOZHveDMGnKfl4VVKbsqtuj jkkAnjnmIaIiF4U4TriXcmntkku7kT7e =OWKB -----END PGP SIGNATURE----- --Sig_/zsd_OU=775VxhYDkNqcMBKx-- -- gentoo-dev@lists.gentoo.org mailing list