[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-dialup/freeradius: freeradius-2.0.3.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-dialup/freeradius: freeradius-2.0.3.ebuild

[Thomas Anderson]

[-- Attachment #1: Type: text/plain, Size: 724 bytes --]

On Sun, Apr 13, 2008 at 05:41:18PM +0000, Alin Nastac (mrness) wrote:
> mrness      08/04/13 17:41:18
> 
>   Modified:             ChangeLog
>   Added:                freeradius-2.0.3.ebuild
>   Log:
>   Version bump.
>   (Portage version: 2.1.4.4)

> src_install() {
> 	mv "${D}/usr/share/doc/${PN}" "${D}/usr/share/doc/${PF}"
> 	gzip -f -9 "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}
Doesn't this gzip command rather defeat the purpose of $PORTAGE_COMPRESS
and $PORTAGE_COMPRESS_FLAGS?

It seems this might work better:

    ecompress "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}

This way a user can opt to use bzip2,lzma, or no compression at all.
> -- 
> gentoo-commits@lists.gentoo.org mailing list
> 

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-dialup/freeradius: freeradius-2.0.3.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

On Sunday 13 April 2008, Thomas Anderson wrote:
> On Sun, Apr 13, 2008 at 05:41:18PM +0000, Alin Nastac (mrness) wrote:
> > mrness      08/04/13 17:41:18
> >
> >   Modified:             ChangeLog
> >   Added:                freeradius-2.0.3.ebuild
> >   Log:
> >   Version bump.
> >   (Portage version: 2.1.4.4)
> >
> > src_install() {
> > 	mv "${D}/usr/share/doc/${PN}" "${D}/usr/share/doc/${PF}"
> > 	gzip -f -9 "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}
>
> Doesn't this gzip command rather defeat the purpose of $PORTAGE_COMPRESS
> and $PORTAGE_COMPRESS_FLAGS?

it doesnt defeat it as ecompress will decompress things automatically.  it 
just makes the call pointless.

> It seems this might work better:
>
>     ecompress "${D}/usr/share/doc/${PF}"/{rfc/*.txt,*}
>
> This way a user can opt to use bzip2,lzma, or no compression at all.

no need to call ecompress as we already have a function to do what is needed: 
prepalldocs
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]