From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1JgPez-0004H9-Ju for garchives@archives.gentoo.org; Mon, 31 Mar 2008 19:27:13 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 782D3E01B8; Mon, 31 Mar 2008 19:27:12 +0000 (UTC) Received: from smtp1-g19.free.fr (smtp1-g19.free.fr [212.27.42.27]) by pigeon.gentoo.org (Postfix) with ESMTP id 5183EE01B8 for ; Mon, 31 Mar 2008 19:27:12 +0000 (UTC) Received: from smtp1-g19.free.fr (localhost.localdomain [127.0.0.1]) by smtp1-g19.free.fr (Postfix) with ESMTP id 71A671AB2E1 for ; Mon, 31 Mar 2008 21:27:11 +0200 (CEST) Received: from eusebe (mal35-4-88-164-237-103.fbx.proxad.net [88.164.237.103]) by smtp1-g19.free.fr (Postfix) with ESMTP id B87E61AB2C5 for ; Mon, 31 Mar 2008 21:27:08 +0200 (CEST) Date: Mon, 31 Mar 2008 21:26:29 +0200 From: Thomas de Grenier de Latour To: gentoo-dev@lists.gentoo.org Subject: Re: User patches (Was: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild) Message-ID: <20080331212629.3e128443@eusebe> In-Reply-To: <47F10524.4080406@gentoo.org> References: <20080330054051.GE24954@comet.had1.or.comcast.net> <20080330191922.GA32327@aerie.halcy0n.com> <200803301544.55878.vapier@gentoo.org> <20080330211844.GB32327@aerie.halcy0n.com> <47F10524.4080406@gentoo.org> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.9; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: ee65806c-2097-48e9-a80b-0a991aff801d X-Archives-Hash: b1fc4e65150870cb4b88767620d1e1d3 On 2008/03/31, Vlastimil Babka wrote: > I think that maybe we should first introduce new patching phase and > then make this user patch really usable feature. For example if you > want to patch something that's input to running autotools, doing it > in post_src_unpack is too late... > Not really. I'm using Ed Catmur's bashrc, and his post_src_unpack hook for /etc/portage/patches/ can detect when running autotools is needed: http://sources.catmur.co.uk/viewvc/svn/gentoo/phase_hooks.d/post_src_unpack/portage-patches?view=co http://catmur.co.uk/gentoo/ Sure, this detection (based on what files are modified) may not work in all cases. And when it does, then autotools may fail too (basically wherever an ebuild writer would have needed to do do more than just "inherit autotools" before running "eautofoo"). But it's still pretty cool. -- TGL. -- gentoo-dev@lists.gentoo.org mailing list