public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Mark Loeser <halcy0n@gentoo.org>
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild
Date: Sun, 30 Mar 2008 20:39:14 -0400	[thread overview]
Message-ID: <200803302039.14615.vapier@gentoo.org> (raw)
In-Reply-To: <20080330211844.GB32327@aerie.halcy0n.com>

[-- Attachment #1: Type: text/plain, Size: 2115 bytes --]

On Sunday 30 March 2008, Mark Loeser wrote:
> Mike Frysinger <vapier@gentoo.org> said:
> > On Sunday 30 March 2008, Mark Loeser wrote:
> > > Actually, I'd say this should just be removed.  If a user wants to
> > > apply a patch, they can put their own ebuild into an overlay and do it
> > > themselves (presumably if they want to patch something, they'll know
> > > how to make the simple modifications to an ebuild).  By allowing the
> > > user to arbitrarily patch something means we have no idea what the user
> > > has built and is filing a bug about.  If they installed an ebuild from
> > > an overlay it is a lot easier to identify what they built.  Sure, they
> > > could patch the ebuild in their tree, but by supporting user supplied
> > > patches easily in this way, we are encouraging them to patch things
> > > without our knowledge.  If we start supporting this across the board, I
> > > can see bugs being filed when their patches break and they don't
> > > understand what is happening.
> >
> > that's actually exactly what i'm encouraging.  i'm not worried about such
> > issues as they're easily resolved by people posting the full build log.
>
> Which is great, but I think this is something we should discuss and
> figure out if this is something we want to introduce into the tree (too
> late now, but better late than never).  If it is something we want to
> move forward with, it should be introduced at the package manager level
> instead of being an in-tree package manager specific feature.
>
> I'm coming at this from a QA perspective and if we want to do it for one
> package, it should be introduced for all.  We should document it and
> know how to support it as well.

there is no package-manager specificness here.  it's already completely doable 
from a user perspective, just having it in the ebuild makes my life and 
users' lives easier.  i'm using it in packages that tend to have a lot of 
extraneous patchsets associated with them.  the random patches were punted 
from ebuilds and now it's up to the user to maintain the feature sets.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

  parent reply	other threads:[~2008-03-31  0:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Jfeop-0005oU-6S@stork.gentoo.org>
2008-03-30  5:40 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild Donnie Berkholz
2008-03-30 16:13   ` Mike Frysinger
2008-03-30 19:19   ` Mark Loeser
2008-03-30 19:44     ` Mike Frysinger
2008-03-30 21:18       ` Mark Loeser
2008-03-30 21:42         ` Markus Ullmann
2008-03-30 21:46         ` Ciaran McCreesh
2008-03-30 21:57           ` Petteri Räty
2008-03-31  0:39         ` Mike Frysinger [this message]
2008-03-31  6:21           ` Duncan
2008-03-31 10:15             ` Peter Volkov
2008-03-31 18:04               ` Duncan
2008-03-31 15:37         ` User patches (Was: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild) Vlastimil Babka
2008-03-31 19:26           ` Thomas de Grenier de Latour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803302039.14615.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=halcy0n@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox