From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Jg341-0003SU-QG for garchives@archives.gentoo.org; Sun, 30 Mar 2008 19:19:34 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F2893E03A5; Sun, 30 Mar 2008 19:19:31 +0000 (UTC) Received: from aerie.halcy0n.com (aerie.halcy0n.com [65.98.89.194]) by pigeon.gentoo.org (Postfix) with ESMTP id D2330E03A5 for ; Sun, 30 Mar 2008 19:19:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by aerie.halcy0n.com (Postfix) with ESMTP id 8DB687DD0A for ; Sun, 30 Mar 2008 15:19:31 -0400 (EDT) X-Virus-Scanned: amavisd-new at halcy0n.com Received: from aerie.halcy0n.com ([127.0.0.1]) by localhost (halcy0n.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qXCPSQCsQKXI for ; Sun, 30 Mar 2008 15:19:22 -0400 (EDT) Received: by aerie.halcy0n.com (Postfix, from userid 1000) id 48FF67DCE5; Sun, 30 Mar 2008 15:19:22 -0400 (EDT) Date: Sun, 30 Mar 2008 15:19:22 -0400 From: Mark Loeser To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild Message-ID: <20080330191922.GA32327@aerie.halcy0n.com> References: <20080330054051.GE24954@comet.had1.or.comcast.net> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <20080330054051.GE24954@comet.had1.or.comcast.net> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 5683be91-9828-4c55-8f6c-9ead2e24d53e X-Archives-Hash: 35b7c97289f43164d411ab1071911f75 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=utf8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Donnie Berkholz said: > On 17:26 Sat 29 Mar , Mike Frysinger (vapier) wrote: > > 1.1 sys-apps/iproute2/iproute2-2.6.24.20080108.ebuild > >=20 > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/iproute= 2/iproute2-2.6.24.20080108.ebuild?rev=3D1.1&view=3Dmarkup > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/iproute= 2/iproute2-2.6.24.20080108.ebuild?rev=3D1.1&content-type=3Dtext/plain >=20 > > local check base=3D${PORTAGE_CONFIGROOT}/etc/portage/patches > > for check in {${CATEGORY}/${PF},${CATEGORY}/${P},${CATEGORY}/${PN}}; do > > EPATCH_SOURCE=3D${base}/${CTARGET}/${check} > > [[ -r ${EPATCH_SOURCE} ]] || EPATCH_SOURCE=3D${base}/${CHOST}/${check} > > [[ -r ${EPATCH_SOURCE} ]] || EPATCH_SOURCE=3D${base}/${check} > > if [[ -d ${EPATCH_SOURCE} ]] ; then > > EPATCH_SUFFIX=3D"patch" > > EPATCH_FORCE=3D"yes" \ > > EPATCH_MULTI_MSG=3D"Applying user patches from ${EPATCH_SOURCE} ..."= \ > > epatch > > break > > fi > > done >=20 > This looks like it should be generic code somewhere else. Actually, I'd say this should just be removed. If a user wants to apply a patch, they can put their own ebuild into an overlay and do it themselves (presumably if they want to patch something, they'll know how to make the simple modifications to an ebuild). By allowing the user to arbitrarily patch something means we have no idea what the user has built and is filing a bug about. If they installed an ebuild from an overlay it is a lot easier to identify what they built. Sure, they could patch the ebuild in their tree, but by supporting user supplied patches easily in this way, we are encouraging them to patch things without our knowledge. If we start supporting this across the board, I can see bugs being filed when their patches break and they don't understand what is happening. Thanks, --=20 Mark Loeser email - halcy0n AT gentoo DOT org email - mark AT halcy0n DOT com web - http://www.halcy0n.com --82I3+IH0IqGh5yIs Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQFH7+e6CRZPokWLroQRApzsAKCKB2R43QDpMZ2UN7lTEWq/CYrPRgCeOFIS ArllCVOYtTNnpauo35posrs= =yqU5 -----END PGP SIGNATURE----- --82I3+IH0IqGh5yIs-- -- gentoo-dev@lists.gentoo.org mailing list