From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Jg3Pc-0005V3-Du for garchives@archives.gentoo.org; Sun, 30 Mar 2008 19:41:52 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 87AD4E03F5; Sun, 30 Mar 2008 19:41:50 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 41A5EE03F6 for ; Sun, 30 Mar 2008 19:41:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 9D7C967460; Sun, 30 Mar 2008 19:41:43 +0000 (UTC) From: Mike Frysinger Organization: wh0rd.org To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/iproute2: ChangeLog iproute2-2.6.24.20080108.ebuild Date: Sun, 30 Mar 2008 15:44:55 -0400 User-Agent: KMail/1.9.7 Cc: Mark Loeser References: <20080330054051.GE24954@comet.had1.or.comcast.net> <20080330191922.GA32327@aerie.halcy0n.com> In-Reply-To: <20080330191922.GA32327@aerie.halcy0n.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart15499803.p4LqmovjCO"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200803301544.55878.vapier@gentoo.org> X-Archives-Salt: e3a88e79-27d6-4d35-b581-8badaa145d4f X-Archives-Hash: 1c230baa6185b57456f376cb869af684 --nextPart15499803.p4LqmovjCO Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 30 March 2008, Mark Loeser wrote: > Donnie Berkholz said: > > On 17:26 Sat 29 Mar , Mike Frysinger (vapier) wrote: > > > 1.1 sys-apps/iproute2/iproute2-2.6.24.20080108.ebuild > > > > > > file : > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/iproute2/ipr= ou > > >te2-2.6.24.20080108.ebuild?rev=3D1.1&view=3Dmarkup plain: > > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/iproute2/ipr= ou > > >te2-2.6.24.20080108.ebuild?rev=3D1.1&content-type=3Dtext/plain > > > > > > local check base=3D${PORTAGE_CONFIGROOT}/etc/portage/patches > > > for check in {${CATEGORY}/${PF},${CATEGORY}/${P},${CATEGORY}/${PN}}; > > > do EPATCH_SOURCE=3D${base}/${CTARGET}/${check} > > > [[ -r ${EPATCH_SOURCE} ]] || EPATCH_SOURCE=3D${base}/${CHOST}/${che= ck} > > > [[ -r ${EPATCH_SOURCE} ]] || EPATCH_SOURCE=3D${base}/${check} > > > if [[ -d ${EPATCH_SOURCE} ]] ; then > > > EPATCH_SUFFIX=3D"patch" > > > EPATCH_FORCE=3D"yes" \ > > > EPATCH_MULTI_MSG=3D"Applying user patches from ${EPATCH_SOURCE} ..= =2E" \ > > > epatch > > > break > > > fi > > > done > > > > This looks like it should be generic code somewhere else. > > Actually, I'd say this should just be removed. If a user wants to apply > a patch, they can put their own ebuild into an overlay and do it > themselves (presumably if they want to patch something, they'll know how > to make the simple modifications to an ebuild). By allowing the user to > arbitrarily patch something means we have no idea what the user has > built and is filing a bug about. If they installed an ebuild from an > overlay it is a lot easier to identify what they built. Sure, they > could patch the ebuild in their tree, but by supporting user supplied > patches easily in this way, we are encouraging them to patch things > without our knowledge. If we start supporting this across the board, I > can see bugs being filed when their patches break and they don't > understand what is happening. that's actually exactly what i'm encouraging. i'm not worried about such=20 issues as they're easily resolved by people posting the full build log. =2Dmike --nextPart15499803.p4LqmovjCO Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iQIVAwUAR+/tt0FjO5/oN/WBAQKu9g/9HBvHBF8ZOjiABEpYC8KR6PDIytyiSFMB XSDOwapwboAlXZa26RpN2XjxlFznmNnNZbe4yjcL1MIkb0ACXcb/THfMmE3CH8jq aO2N4Fr8C6HqYY075vG1lPm4O5dvtUbsQJFUHNPWaw0HyRBqPjlgeRfX4TiKIkT7 u1kPXzbKOezw53tRS7VVObDjJ/R4onHpt+KgKyVsljQsxcg/F4QmBY+Xe97eL5Dq LqcPX0x3QSF93y6p4PvTnkRoe1hhgd4HzLvkx7ifnU389fwg9sMdY+cOsOEQOwUo MSYnZSUfshtigjCd8Hofa1CTcZb3lGijhGH17SrLcAs6M7TnvjEJeBR5jXBIWN9I EqlpUQktyHNjzj3k5XYQEguCbPIjVfGLrpJntNTNKB49zXSpMUqx22DYaGnSDy6u km1RH6FyKnWT1xBsWAZVk4mGy3aeEJoSoW48nI0aOhspsO/cDT9pwR7Ufe3D+2kB UNHgVzM+UFjQO5SsFrnOv3BJTuwQ/OGEBT3t3SKO2YrCObmKYlITYMK4MKvXeAGQ 0jKsmgjA+M6R7fuCaJ7jFteuHoXTBvmLfyAjeSi8J8e644ezPRGOPPOIbMdP/RnK Jwy7X6kck2uZx42luUKB6rWVPVsrH7SiLpUSZuYEKxayzcOSuiKL0oe5hxfR8zNN bflX88oIIV4= =lJ3j -----END PGP SIGNATURE----- --nextPart15499803.p4LqmovjCO-- -- gentoo-dev@lists.gentoo.org mailing list