From: Mike Frysinger <vapier@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Ulrich Mueller <ulm@gentoo.org>, compnerd@gentoo.org
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild
Date: Sun, 30 Mar 2008 12:25:24 -0400 [thread overview]
Message-ID: <200803301225.25148.vapier@gentoo.org> (raw)
In-Reply-To: <18415.12354.596402.957821@a1ihome1.kph.uni-mainz.de>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Sunday 30 March 2008, Ulrich Mueller wrote:
> >>>>> On Sat, 29 Mar 2008, Donnie Berkholz wrote:
> >
> > On 19:37 Sat 29 Mar , Saleem Abdulrasool (compnerd) wrote:
> >> 1.1 app-editors/leafpad/leafpad-0.8.14.ebuild
> >>
> >> src_compile() {
> >> econf --enable-chooser --enable-print $(use_enable emacs)
> >> emake
> >> }
> >
> > emake doesn't die on failure.
>
> And IMHO the "emacs" USE flag should not be used here:
>
> $ ./configure -hs
> Configuration of Leafpad 0.8.12:
>
> Optional Features:
> [...]
> --enable-emacs implement Emacs key theme (experimental)
>
> $ equery uses =leafpad-0.8.12
> [...]
> + + emacs : Adds support for GNU Emacs
>
> As its description says, the flag is intended for GNU Emacs support
> which is not the case here.
i think the USE flag makes sense. perhaps the description should be changed.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]
next prev parent reply other threads:[~2008-03-30 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Jfgrd-0007H6-7k@stork.gentoo.org>
2008-03-30 5:43 ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/leafpad: ChangeLog leafpad-0.8.14.ebuild Donnie Berkholz
2008-03-30 6:16 ` Ulrich Mueller
2008-03-30 16:25 ` Mike Frysinger [this message]
2008-03-30 17:07 ` Ulrich Mueller
2008-03-30 17:23 ` Mike Frysinger
2008-03-31 6:26 ` Marijn Schouten (hkBst)
2008-03-31 15:25 ` Mike Frysinger
2008-03-31 16:24 ` Christian Faulhammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803301225.25148.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=compnerd@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox