public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, rbrown@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ruby/rubygems: ChangeLog rubygems-1.1.0-r0.ebuild
Date: Sat, 29 Mar 2008 22:36:31 -0700	[thread overview]
Message-ID: <20080330053631.GB24954@comet.had1.or.comcast.net> (raw)
In-Reply-To: <E1Jfcn7-0004GH-24@stork.gentoo.org>

On 15:16 Sat 29 Mar     , Richard Brown (rbrown) wrote:
> 1.1                  dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-ruby/rubygems/rubygems-1.1.0-r0.ebuild?rev=1.1&content-type=text/plain
> 
> Index: rubygems-1.1.0-r0.ebuild

What was the purpose of bumping this to an -r0? I didn't see any 
previous rubygems ebuilds doing this.

I'm probably wrong about this, but my naive impression is that it looks 
to me like an attempt to force someone else to bring up the issue that 
indeed did come up, rather than doing it yourself.

> 	dosym /usr/bin/gem18 /usr/bin/gem || die "dosym gem failed"

No big deal, but it would be nice to do a relative symlink here.

> 	#This is used to update rubygems, do not want.
> 	rm "${D}/usr/bin/update_rubygems18"
> 
> 	dodoc README
> 	if use examples; then
> 		cp -pPR examples "${D}/usr/share/doc/${PF}"
> 	fi
> 
> 	cp "${FILESDIR}/auto_gem.rb" "${D}"/$(${RUBY} -r rbconfig -e 'print Config::CONFIG["sitedir"]')
> 	doenvd "${FILESDIR}/10rubygems"
> 
> 	if use server; then
> 		newinitd "${FILESDIR}/init.d-gem_server" gem_server
> 		newconfd "${FILESDIR}/conf.d-gem_server" gem_server
> 	fi

Might be nice to die if some of these fail.

> }
> 
> pkg_postinst()
> {
> 	ver=$(${RUBY} -r rbconfig -e 'print Config::CONFIG["ruby_version"]')

Shouldn't this be preserved in the environment from src_install()? Rerunning it seems like 
it could allow a change in ruby version to cause issues.

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list



       reply	other threads:[~2008-03-30  5:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1Jfcn7-0004GH-24@stork.gentoo.org>
2008-03-30  5:36 ` Donnie Berkholz [this message]
2008-03-31 21:13   ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-ruby/rubygems: ChangeLog rubygems-1.1.0-r0.ebuild Richard Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080330053631.GB24954@comet.had1.or.comcast.net \
    --to=dberkholz@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=rbrown@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox