From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Jcd0n-0001XP-QX for garchives@archives.gentoo.org; Fri, 21 Mar 2008 08:54:06 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BBAEFE078B; Fri, 21 Mar 2008 08:54:04 +0000 (UTC) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by pigeon.gentoo.org (Postfix) with ESMTP id 7118CE078B for ; Fri, 21 Mar 2008 08:54:04 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id 13so1784773fge.14 for ; Fri, 21 Mar 2008 01:54:03 -0700 (PDT) Received: by 10.82.161.19 with SMTP id j19mr6809112bue.9.1206089643576; Fri, 21 Mar 2008 01:54:03 -0700 (PDT) Received: from localhost ( [213.121.151.206]) by mx.google.com with ESMTPS id y18sm3681799fkd.17.2008.03.21.01.54.02 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 21 Mar 2008 01:54:03 -0700 (PDT) Date: Fri, 21 Mar 2008 07:54:26 +0000 From: Ciaran McCreesh To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: Remaining PMS todo list etc Message-ID: <20080321075426.54db71b1@googlemail.com> In-Reply-To: References: <20080319182717.69c0f975@snowcone> <20080320044503.3c29a663@sheridan.genone.homeip.net> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.10.14; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Fwc79lJeSCdjg3m34v7NQeA"; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Archives-Salt: 820ea8bb-17e8-4d45-8d9b-e62d2d14ef6c X-Archives-Hash: 215324ad2669b1f433cf41c3513a9272 --Sig_/Fwc79lJeSCdjg3m34v7NQeA Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 20 Mar 2008 18:02:31 -0600 Ryan Hill wrote: > > How about just checking EUID =3D=3D 0 in src_test and skip the tests > > (with a ewarn message) if it doesn't match your needs? >=20 > I thought I remembered someone raising a stink about checking > permissions being a race condition because the condition can change > between the checking and performing the action. Maybe that was only > about write permissions... That's in cases like if [[ -w foo ]] ; then blah foo ; fi . Checking a variable that's constant for the phase is not racy. > If checking EUID is an acceptable method, > it should be relatively simple to write an eclass to handle the > common cases and have ebuilds use that instead of checking $FEATURES > (which i do think is a bug). Does it really need an eclass for something so simple? --=20 Ciaran McCreesh --Sig_/Fwc79lJeSCdjg3m34v7NQeA Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQFH42m196zL6DUtXhERAl2PAKCyUXYVeLhcwFOMaz8GGCWZxTEvEwCgwy9E gl+XkBegG6mibTAaBfxMVH0= =fQs8 -----END PGP SIGNATURE----- --Sig_/Fwc79lJeSCdjg3m34v7NQeA-- -- gentoo-dev@lists.gentoo.org mailing list