Re: [gentoo-dev] Re: Remaining PMS todo list etc

[Ciaran McCreesh <ciaran.mccreesh@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Thu, 20 Mar 2008 18:02:31 -0600
Ryan Hill <dirtyepic@gentoo.org> wrote:
> > How about just checking EUID == 0 in src_test and skip the tests
> > (with a ewarn message) if it doesn't match your needs?
> 
> I thought I remembered someone raising a stink about checking
> permissions being a race condition because the condition can change
> between the checking and performing the action.  Maybe that was only
> about write permissions...

That's in cases like if [[ -w foo ]] ; then blah foo ; fi . Checking a
variable that's constant for the phase is not racy.

> If checking EUID is an acceptable method,
> it should be relatively simple to write an eclass to handle the
> common cases and have ebuilds use that instead of checking $FEATURES
> (which i do think is a bug).

Does it really need an eclass for something so simple?

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]