[gentoo-dev] Remaining PMS todo list etc

[gentoo-dev] Remaining PMS todo list etc

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 2299 bytes --]

There's an updated, pre-built copy of current PMS at:

    http://dev.gentoo.org/~spb/pms.pdf

And source at:

    http://git.overlays.gentoo.org/gitweb/?p=proj/pms.git

And "PMS for people who haven't been paying attention" at:

    http://archives.gentoo.org/gentoo-dev/msg_4ac035019b5264e5b9c176493bcc6b5b.xml

And an explanation of kdebuild at:

    http://archives.gentoo.org/gentoo-dev/msg_0594dd89e411526c2a68cae9916c6a16.xml

And the following note about bugs: Please stop making bugs with
[EAPI-2] or whatever in the title. Use [Future EAPI] unless you have a
definite agreement from absolutely everybody and their dog that it's
going into EAPI 2. I had to go through and fix a load of bugs saying
[EAPI 1] and don't really want to do it again.

Things still left to do for PMS are as follows. Well-informed people
are encouraged to comment and provide patches to pms-bugs@g.o. If you
aren't sure whether you're well-informed, you aren't.

* Someone needs to write up dohtml.

* 178092: Someone needs to write up package.use.

* 170697: can we consider profile masks to be in the same category as
  'use? ( ) : ( )' and thus not worth documenting?

* 174319: make.defaults needs to be parsed by things other than bash.
  Just how much of bash's syntax do we support?

* 174330: PMS currently bans interactivity except in pkg_config.

* 174335: Some ebuild use FEATURES. Can we get them to stop doing that,
  or do we have to force package managers to emulate it?

* 174536: Currently there's no way to tell whether you have a cat/pkg
  or a cat/pkg-ver, and in no place does anything have to do so. Do we
  want to introduce new restrictions so that people can do that?

* 175246: Portage sets EBUILD_PHASE=depend for the metadata source. Do
  we want to enforce this?

* 188449: The eight digit limit for version parts is still in. Do we
  want to keep it?

* 196561: PMS describes the ~ operator as working the way developers
  expect it to work, but Portage doesn't quite do that.

* 202631: PMS doesn't document profile.bashrc. Currently, Paludis
  ignores it because most of the code that ends up there is extremely
  Portage specific. Do we document profile.bashrc and make it much more
  constrained?

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: Remaining PMS todo list etc

[Ryan Hill]

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

Ciaran McCreesh wrote:
> There's an updated, pre-built copy of current PMS at:
> 
>     http://dev.gentoo.org/~spb/pms.pdf

Thanks for keeping up with this.

> * 174335: Some ebuild use FEATURES. Can we get them to stop doing that,
>   or do we have to force package managers to emulate it?

We seriously need a PM-independent way of saying "run the testsuite", "run the 
testsuite with user privledges", and "run the testsuite with root privledges if 
you can, otherwise forget it".  Also required is the ability to make test 
failures non-fatal on a per-package basis, though this probably has nothing to 
do with the PMS.


-- 
fonts, gcc-porting,                               by design, by neglect
mips, treecleaner,                        for a fact or just for effect
wxwidgets @ gentoo     EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: Remaining PMS todo list etc

[Marius Mauch]

[-- Attachment #1: Type: text/plain, Size: 1075 bytes --]

On Wed, 19 Mar 2008 18:32:41 -0600
Ryan Hill <dirtyepic@gentoo.org> wrote:

> Ciaran McCreesh wrote:
> > There's an updated, pre-built copy of current PMS at:
> > 
> >     http://dev.gentoo.org/~spb/pms.pdf
> 
> Thanks for keeping up with this.
> 
> > * 174335: Some ebuild use FEATURES. Can we get them to stop doing
> > that, or do we have to force package managers to emulate it?
> 
> We seriously need a PM-independent way of saying "run the testsuite",
> "run the testsuite with user privledges", and "run the testsuite with
> root privledges if you can, otherwise forget it".  Also required is
> the ability to make test failures non-fatal on a per-package basis,
> though this probably has nothing to do with the PMS.

How about just checking EUID == 0 in src_test and skip the tests (with a
ewarn message) if it doesn't match your needs?

Marius

-- 
Public Key at http://www.genone.de/info/gpg-key.pub

In the beginning, there was nothing. And God said, 'Let there be
Light.' And there was still nothing, but you could see a bit better.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: Remaining PMS todo list etc

[Ryan Hill]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

Marius Mauch wrote:
> On Wed, 19 Mar 2008 18:32:41 -0600

> Ryan Hill <dirtyepic@gentoo.org> wrote:
>> We seriously need a PM-independent way of saying "run the testsuite",
>> "run the testsuite with user privledges", and "run the testsuite with
>> root privledges if you can, otherwise forget it".  Also required is
>> the ability to make test failures non-fatal on a per-package basis,
>> though this probably has nothing to do with the PMS.

> How about just checking EUID == 0 in src_test and skip the tests (with a
> ewarn message) if it doesn't match your needs?

I thought I remembered someone raising a stink about checking permissions being 
a race condition because the condition can change between the checking and 
performing the action.  Maybe that was only about write permissions...  If 
checking EUID is an acceptable method, it should be relatively simple to write 
an eclass to handle the common cases and have ebuilds use that instead of 
checking $FEATURES (which i do think is a bug).


-- 
fonts, gcc-porting,                               by design, by neglect
mips, treecleaner,                        for a fact or just for effect
wxwidgets @ gentoo     EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: Remaining PMS todo list etc

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

On Thu, 20 Mar 2008 18:02:31 -0600
Ryan Hill <dirtyepic@gentoo.org> wrote:
> > How about just checking EUID == 0 in src_test and skip the tests
> > (with a ewarn message) if it doesn't match your needs?
> 
> I thought I remembered someone raising a stink about checking
> permissions being a race condition because the condition can change
> between the checking and performing the action.  Maybe that was only
> about write permissions...

That's in cases like if [[ -w foo ]] ; then blah foo ; fi . Checking a
variable that's constant for the phase is not racy.

> If checking EUID is an acceptable method,
> it should be relatively simple to write an eclass to handle the
> common cases and have ebuilds use that instead of checking $FEATURES
> (which i do think is a bug).

Does it really need an eclass for something so simple?

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: Remaining PMS todo list etc

[Ryan Hill]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

Ciaran McCreesh wrote:
> On Thu, 20 Mar 2008 18:02:31 -0600
> Ryan Hill <dirtyepic@gentoo.org> wrote:
>>> How about just checking EUID == 0 in src_test and skip the tests
>>> (with a ewarn message) if it doesn't match your needs?
>> I thought I remembered someone raising a stink about checking
>> permissions being a race condition because the condition can change
>> between the checking and performing the action.  Maybe that was only
>> about write permissions...
> 
> That's in cases like if [[ -w foo ]] ; then blah foo ; fi . Checking a
> variable that's constant for the phase is not racy.
> 
>> If checking EUID is an acceptable method,
>> it should be relatively simple to write an eclass to handle the
>> common cases and have ebuilds use that instead of checking $FEATURES
>> (which i do think is a bug).
> 
> Does it really need an eclass for something so simple?

Considering the number of ebuilds that check FEATURES, disable tests altogether, 
  or just do nothing and fail for half our users, against the number that do it 
correctly...   apparently yeah.  The simpler we make it to use, the more people 
will use it.

On the other hand, it might be better to just document the common cases along 
with some example code in the Dev Guide.  I'd be happy with doing that.


-- 
fonts, gcc-porting,                               by design, by neglect
mips, treecleaner,                        for a fact or just for effect
wxwidgets @ gentoo     EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: Remaining PMS todo list etc

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Wed, 19 Mar 2008 18:32:41 -0600
Ryan Hill <dirtyepic@gentoo.org> wrote:
> > * 174335: Some ebuild use FEATURES. Can we get them to stop doing
> > that, or do we have to force package managers to emulate it?
> 
> We seriously need a PM-independent way of saying "run the testsuite",
> "run the testsuite with user privledges", and "run the testsuite with
> root privledges if you can, otherwise forget it".  Also required is
> the ability to make test failures non-fatal on a per-package basis,
> though this probably has nothing to do with the PMS.

Sounds like you need to write your own src_test for these situations.

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: Remaining PMS todo list etc

[Christian Faulhammer]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

Hi,

Ciaran McCreesh <ciaran.mccreesh@googlemail.com>:

> On Wed, 19 Mar 2008 18:32:41 -0600
> Ryan Hill <dirtyepic@gentoo.org> wrote:
> > > * 174335: Some ebuild use FEATURES. Can we get them to stop doing
> > > that, or do we have to force package managers to emulate it?
> > 
> > We seriously need a PM-independent way of saying "run the
> > testsuite", "run the testsuite with user privledges", and "run the
> > testsuite with root privledges if you can, otherwise forget it".
> > Also required is the ability to make test failures non-fatal on a
> > per-package basis, though this probably has nothing to do with the
> > PMS.
> 
> Sounds like you need to write your own src_test for these situations.

 
if has userpriv ${FEATURES} && ! has usersandbox ${FEATURES};then
	make check-local || die "test suite failed"
else
	ewarn "Activate FEATURES=userpriv and deactivate \
		FEATURES=usersandbox to run testsuite."
fi

^ That's mlocate, mysql also tests for FEATURES.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: Remaining PMS todo list etc

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Thu, 20 Mar 2008 08:52:40 +0100
Christian Faulhammer <opfer@gentoo.org> wrote:
> if has userpriv ${FEATURES} && ! has usersandbox ${FEATURES};then
> 	make check-local || die "test suite failed"
> else
> 	ewarn "Activate FEATURES=userpriv and deactivate \
> 		FEATURES=usersandbox to run testsuite."
> fi
> 
> ^ That's mlocate, mysql also tests for FEATURES.

Yeah, and that's a strong case for why we don't want FEATURES used in
ebuilds -- the ebuild is copying package manager internal logic that
has changed in the past and may well change in the future.

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: Remaining PMS todo list etc

[Christian Faulhammer]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

Hi,

Ciaran McCreesh <ciaran.mccreesh@googlemail.com>:

> On Thu, 20 Mar 2008 08:52:40 +0100
> Christian Faulhammer <opfer@gentoo.org> wrote:
> > if has userpriv ${FEATURES} && ! has usersandbox ${FEATURES};then
> > 	make check-local || die "test suite failed"
> > else
> > 	ewarn "Activate FEATURES=userpriv and deactivate \
> > 		FEATURES=usersandbox to run testsuite."
> > fi
> > 
> > ^ That's mlocate, mysql also tests for FEATURES.
> 
> Yeah, and that's a strong case for why we don't want FEATURES used in
> ebuilds -- the ebuild is copying package manager internal logic that
> has changed in the past and may well change in the future.

 Great, I accept that it is wrong, but can you tell me how to actually
rewrite it?  Test for capabilities (read/write) on files or is there a
sane way to tell?

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: Remaining PMS todo list etc

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

On Fri, 21 Mar 2008 12:47:37 +0100
Christian Faulhammer <opfer@gentoo.org> wrote:
>  Great, I accept that it is wrong, but can you tell me how to actually
> rewrite it?  Test for capabilities (read/write) on files or is there a
> sane way to tell?

Uh, test the condition that you actually want to test... Under what
exact circumstances will tests succeed or not succeed?

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]