[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-power/nut: ChangeLog nut-2.2.1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-power/nut: ChangeLog nut-2.2.1.ebuild

[Donnie Berkholz]

On 06:03 Sun 09 Mar     , Rajiv Aaron Manglani (rajiv) wrote:
> 1.1                  sys-power/nut/nut-2.2.1.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-power/nut/nut-2.2.1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-power/nut/nut-2.2.1.ebuild?rev=1.1&content-type=text/plain

> src_install() {

...

> 	eval fperms 0640 ${NUT_PRIVATE_FILES}
> 	eval fowners root:nut ${NUT_PRIVATE_FILES}
> 
> 	eval fperms 0644 ${NUT_PUBLIC_FILES}
> 	eval fowners root:root ${NUT_PUBLIC_FILES}

...

> pkg_postinst() {
> 	# this is to ensure that everybody that installed old versions still has
> 	# correct permissions
> 
> 	chown nut:nut "${ROOT}"/var/lib/nut 2>/dev/null
> 	chmod 0700 "${ROOT}"/var/lib/nut 2>/dev/null
> 
> 	eval chown root:nut "${ROOT}"${NUT_PRIVATE_FILES} 2>/dev/null
> 	eval chmod 0640 "${ROOT}"${NUT_PRIVATE_FILES} 2>/dev/null
> 
> 	eval chown root:root "${ROOT}"${NUT_PUBLIC_FILES} 2>/dev/null
> 	eval chmod 0644 "${ROOT}"${NUT_PUBLIC_FILES} 2>/dev/null

Is there any reason why eval is used in either of these places?

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-power/nut: ChangeLog nut-2.2.1.ebuild

[Jeroen Roovers]

On Sat, 15 Mar 2008 00:20:31 -0700
Donnie Berkholz <dberkholz@gentoo.org> wrote:

> On 06:03 Sun 09 Mar     , Rajiv Aaron Manglani (rajiv) wrote:
> > 1.1                  sys-power/nut/nut-2.2.1.ebuild
> > 
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-power/nut/nut-2.2.1.ebuild?rev=1.1&view=markup
> > plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-power/nut/nut-2.2.1.ebuild?rev=1.1&content-type=text/plain
> 
> > src_install() {
> 
> ...
> 
> > 	eval fperms 0640 ${NUT_PRIVATE_FILES}
> > 	eval fowners root:nut ${NUT_PRIVATE_FILES}
> > 
> > 	eval fperms 0644 ${NUT_PUBLIC_FILES}
> > 	eval fowners root:root ${NUT_PUBLIC_FILES}
> 
> ...
> 
> > pkg_postinst() {
> > 	# this is to ensure that everybody that installed old
> > versions still has # correct permissions
> > 
> > 	chown nut:nut "${ROOT}"/var/lib/nut 2>/dev/null
> > 	chmod 0700 "${ROOT}"/var/lib/nut 2>/dev/null
> > 
> > 	eval chown root:nut "${ROOT}"${NUT_PRIVATE_FILES}
> > 2>/dev/null eval chmod 0640 "${ROOT}"${NUT_PRIVATE_FILES}
> > 2>2>/dev/null
> > 
> > 	eval chown root:root "${ROOT}"${NUT_PUBLIC_FILES}
> > 2>/dev/null eval chmod 0644 "${ROOT}"${NUT_PUBLIC_FILES} 2>/dev/null
> 
> Is there any reason why eval is used in either of these places?

Or indeed why potentially useful debugging information is redirected
to /dev/null... :)


Kind regards,
     JeR
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-power/nut: ChangeLog nut-2.2.1.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

On Saturday 15 March 2008, Donnie Berkholz wrote:
> On 06:03 Sun 09 Mar     , Rajiv Aaron Manglani (rajiv) wrote:
> > 1.1                  sys-power/nut/nut-2.2.1.ebuild
> >
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-power/nut/nut-2.2.1.e
> >build?rev=1.1&view=markup plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-power/nut/nut-2.2.1.e
> >build?rev=1.1&content-type=text/plain
> >
> > src_install() {
>
> ...
>
> > 	eval fperms 0640 ${NUT_PRIVATE_FILES}
> > 	eval fowners root:nut ${NUT_PRIVATE_FILES}
> >
> > 	eval fperms 0644 ${NUT_PUBLIC_FILES}
> > 	eval fowners root:root ${NUT_PUBLIC_FILES}
>
> ...
>
> > pkg_postinst() {
> > 	# this is to ensure that everybody that installed old versions still has
> > 	# correct permissions
> >
> > 	chown nut:nut "${ROOT}"/var/lib/nut 2>/dev/null
> > 	chmod 0700 "${ROOT}"/var/lib/nut 2>/dev/null
> >
> > 	eval chown root:nut "${ROOT}"${NUT_PRIVATE_FILES} 2>/dev/null
> > 	eval chmod 0640 "${ROOT}"${NUT_PRIVATE_FILES} 2>/dev/null
> >
> > 	eval chown root:root "${ROOT}"${NUT_PUBLIC_FILES} 2>/dev/null
> > 	eval chmod 0644 "${ROOT}"${NUT_PUBLIC_FILES} 2>/dev/null
>
> Is there any reason why eval is used in either of these places?

i'd open a bug so it doesnt get lost
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]