From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Ja8Sj-0003Hc-UY for garchives@archives.gentoo.org; Fri, 14 Mar 2008 11:52:38 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 20384E046F; Fri, 14 Mar 2008 11:52:36 +0000 (UTC) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by pigeon.gentoo.org (Postfix) with ESMTP id D3FF3E046F for ; Fri, 14 Mar 2008 11:52:35 +0000 (UTC) Received: by nf-out-0910.google.com with SMTP id f5so1502934nfh.26 for ; Fri, 14 Mar 2008 04:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; bh=YjUadMV9IAOMS+MKy3UB5wDTe/m3E7s6JCuJW3agdD4=; b=hFiImPG0Nh6e8R/mae6PqFGmfdkkjJXVW5mKvJTMca28Qt7+Lgbfo+g27jZmI8nXhmt45+UwvMKdMIJsWj7Ei/qXGsxGLyOFDb1QUACCuM4Z/9/4B2Mt2TAf4TdJ8KZjTFzDQUtKM87vkx8oLuXdJpYmYbM8O0LGCNb/oDhDqTg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:date:user-agent:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=xU6PCMAdqTWUgOuG0dKmf5sUofELIR6Sbgy68ayWL8WgQyGFMD7uF8LEEy590VS6aU2Gy1Q+BRtF5MNSqn10/7tRWIqWBWpIP3644+E4G7ECbEXIqJxrxZT/QwwhWx673WUqR0KjQsiYstX44bm7ymyYShe9Wm2+jmn5oGMf4Y8= Received: by 10.78.201.10 with SMTP id y10mr30638489huf.4.1205495553185; Fri, 14 Mar 2008 04:52:33 -0700 (PDT) Received: from ?192.168.1.67? ( [81.158.99.119]) by mx.google.com with ESMTPS id p32sm8333312hub.35.2008.03.14.04.52.31 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 14 Mar 2008 04:52:32 -0700 (PDT) From: David Leverton To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses Date: Fri, 14 Mar 2008 11:52:28 +0000 User-Agent: KMail/1.9.7 References: <47DA25CF.10205@gentoo.org> In-Reply-To: <47DA25CF.10205@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200803141152.29281.levertond@googlemail.com> X-Archives-Salt: 368faeca-f3b7-4837-b7cc-93b4baa64814 X-Archives-Hash: 4b0efd92b119e80d246053984b016a6c On Friday 14 March 2008 07:14:23 R=E9mi Cardona wrote: > - the gnome2 eclass now has a pkg_preinst, if you do multiple > inherits, make sure that gnome2_pkg_preinst is called too. The > _games_eclass_ is one of those. Maybe worth adding a dummy to the current version of the eclass so that=20 ebuilds can be updated now, instead of suddenly all at once as soon as the= =20 new eclass is committed? > - if you use functions from the gnome2-utils.eclass, things may not > work as expected. The _xfce_eclasses_ are on that list. Are you referring to the need to call gnome2_gconf_savelist in pkg_preinst = if=20 the ebuild/eclass wants to use the gconf functions? What I said above goes= =20 here as well. A couple of things that aren't specific to the new eclass, but I noticed th= em=20 while checking: > #gnome2_pkg_prerm() { > # gnome2_gconf_uninstall > #} Should this really be commented out? If so, might be worth adding a commen= t=20 explaining why - it's not clear whether it's disabled because it's broken, = or=20 not necessary, or whether ebuilds are expected to call gnome2_gconf_uninsta= ll=20 explicitly if they need to. > # Path to gconftool-2 > GCONFTOOL_BIN=3D${GCONFTOOL_BIN:=3D"${ROOT}usr/bin/gconftool-2"} > # Path to scrollkeeper-update >=20 SCROLLKEEPER_UPDATE_BIN=3D${SCROLLKEEPER_UPDATE_BIN:=3D"${ROOT}usr/bin/scro= llkeeper-update"} Those aren't going to work with cross-compilation (which isn't well-support= ed=20 by the current ebuild format, but best to be future-proof), since the=20 executables in ${ROOT} won't be able to run on the build machine. > export GCONF_CONFIG_SOURCE=3D$(${GCONFTOOL_BIN} --get-default-sou= rce) I confess I don't know much about gconf, but that looks as though it'll alw= ays=20 return a path in /, not ${ROOT}, so it'll install the schemas in the /=20 database. -- gentoo-dev@lists.gentoo.org mailing list