[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/cacti: ChangeLog metadata.xml cacti-0.8.7a-r2.ebuild cacti-0.8.6j-r8.ebuild cacti-0.8.7b.ebuild cacti-0.8.7a-r1.ebuild cacti-0.8.7a.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/cacti: ChangeLog metadata.xml cacti-0.8.7a-r2.ebuild cacti-0.8.6j-r8.ebuild cacti-0.8.7b.ebuild cacti-0.8.7a-r1.ebuild cacti-0.8.7a.ebuild

[Donnie Berkholz]

On 13:00 Wed 13 Feb     , Peter Volkov (pva) wrote:
> 1.1                  net-analyzer/cacti/cacti-0.8.7a-r2.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/cacti/cacti-0.8.7a-r2.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-analyzer/cacti/cacti-0.8.7a-r2.ebuild?rev=1.1&content-type=text/plain

> IUSE="snmp bundled-adodb"

> 	!bundled-adodb? ( dev-php/adodb )

> 	use bundled-adodb || sed -i -e \
> 	's:$config\["library_path"\] . "/adodb/adodb.inc.php":"adodb/adodb.inc.php":' \
> 	"${S}"/include/global.php

> 	use bundled-adodb || phpUseFlags="${phpUseFlags} sockets"

Why is bundling even an option? We should always force external packages 
to be used, or we end up with more zlib messes.

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/cacti: ChangeLog metadata.xml cacti-0.8.7a-r2.ebuild cacti-0.8.6j-r8.ebuild cacti-0.8.7b.ebuild cacti-0.8.7a-r1.ebuild cacti-0.8.7a.ebuild

[Peter Volkov]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

В Чтв, 14/02/2008 в 23:19 -0800, Donnie Berkholz пишет: 
> > 	use bundled-adodb || phpUseFlags="${phpUseFlags} sockets"
> 
> Why is bundling even an option? We should always force external packages 
> to be used, or we end up with more zlib messes.

This does no harm and can help in situations when web-app upstream
modified bundled adodb in non compatible way. But well, I'll drop it
from USE flags and define environmental variable inside ebuild to show
that although there is possibility to use bundled adodb it's not
supported.

-- 
Peter.

[-- Attachment #2: Эта часть сообщения подписана цифровой подписью --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/cacti: ChangeLog metadata.xml cacti-0.8.7a-r2.ebuild cacti-0.8.6j-r8.ebuild cacti-0.8.7b.ebuild cacti-0.8.7a-r1.ebuild cacti-0.8.7a.ebuild

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

On Sat, 16 Feb 2008 15:25:43 +0300
Peter Volkov <pva@gentoo.org> wrote:
> This does no harm and can help in situations when web-app upstream
> modified bundled adodb in non compatible way. But well, I'll drop it
> from USE flags and define environmental variable inside ebuild to show
> that although there is possibility to use bundled adodb it's not
> supported.

A USE flag is better than an environment variable. Environment
variables aren't easily visible to the end user beforehand.

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/cacti: ChangeLog metadata.xml cacti-0.8.7a-r2.ebuild cacti-0.8.6j-r8.ebuild cacti-0.8.7b.ebuild cacti-0.8.7a-r1.ebuild cacti-0.8.7a.ebuild

[Donnie Berkholz]

On 15:25 Sat 16 Feb     , Peter Volkov wrote:
> В Чтв, 14/02/2008 в 23:19 -0800, Donnie Berkholz пишет: 
> > > 	use bundled-adodb || phpUseFlags="${phpUseFlags} sockets"
> > 
> > Why is bundling even an option? We should always force external packages 
> > to be used, or we end up with more zlib messes.
> 
> This does no harm and can help in situations when web-app upstream
> modified bundled adodb in non compatible way.

It does do harm. It prevents our package management system from doing 
what it's there to do.

If they're modifying the bundled adodb incompatibly, then the USE flag 
would also be obsolete because you'd need to force it to be bundled. 
What would help more is a good swift kick in the pants to the people 
doing the modifying to tell them to send their changes to adodb 
upstream.

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list