[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/stgit: ChangeLog stgit-0.14.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/stgit: ChangeLog stgit-0.14.ebuild

[Christian Faulhammer]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Hi,

"Greg Kroah-Hartman (gregkh)" <gregkh@gentoo.org>:
> src_install() {
> 	sed -i -e 's-\(prefix:\) ~-\1 /usr-' setup.cfg
> 	distutils_src_install
> 	dodir /usr/share/doc/${PF}
> 	mv ${D}/usr/share/${PN}/examples ${D}/usr/share/doc/${PF}
> 	rmdir ${D}/usr/share/doc/${PN}
> 	dobashcompletion contrib/stgit-completion.bash ${PN}
> }

 Please watch your quotes for variables that can contain spaces, like
${D}.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/stgit: ChangeLog stgit-0.14.ebuild

[Greg KH]

On Wed, Feb 13, 2008 at 06:05:01PM +0100, Christian Faulhammer wrote:
> Hi,
> 
> "Greg Kroah-Hartman (gregkh)" <gregkh@gentoo.org>:
> > src_install() {
> > 	sed -i -e 's-\(prefix:\) ~-\1 /usr-' setup.cfg
> > 	distutils_src_install
> > 	dodir /usr/share/doc/${PF}
> > 	mv ${D}/usr/share/${PN}/examples ${D}/usr/share/doc/${PF}
> > 	rmdir ${D}/usr/share/doc/${PN}
> > 	dobashcompletion contrib/stgit-completion.bash ${PN}
> > }
> 
>  Please watch your quotes for variables that can contain spaces, like
> ${D}.

Hey, I just bumped the ebuild, I didn't write the first one :)

So, what would be the correct fix here?  Something like:
  mv "${D}/usr/share/${PN}/examples" "${D}/usr/share/doc/${PF}"
  rmdir "${D}/usr/share/doc/${PN}"

thanks,

greg k-h
-- 
gentoo-dev@lists.gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/stgit: ChangeLog stgit-0.14.ebuild

[Christian Faulhammer]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

Hi,

Greg KH <gregkh@gentoo.org>:
> Hey, I just bumped the ebuild, I didn't write the first one :)

 No accuses, just review. :)  Touch it and you are responsible.
 
> So, what would be the correct fix here?  Something like:
>   mv "${D}/usr/share/${PN}/examples" "${D}/usr/share/doc/${PF}"
>   rmdir "${D}/usr/share/doc/${PN}"

 Yes.  Around ${D} alone is enough though.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/stgit: ChangeLog stgit-0.14.ebuild

[Greg KH]

On Wed, Feb 13, 2008 at 06:45:42PM +0100, Christian Faulhammer wrote:
> Hi,
> 
> Greg KH <gregkh@gentoo.org>:
> > Hey, I just bumped the ebuild, I didn't write the first one :)
> 
>  No accuses, just review. :)  Touch it and you are responsible.
>  
> > So, what would be the correct fix here?  Something like:
> >   mv "${D}/usr/share/${PN}/examples" "${D}/usr/share/doc/${PF}"
> >   rmdir "${D}/usr/share/doc/${PN}"
> 
>  Yes.  Around ${D} alone is enough though.

Ok, thanks, changed in the new release.

greg k-h
-- 
gentoo-dev@lists.gentoo.org mailing list