[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/qdbm: ChangeLog qdbm-1.8.77.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/qdbm: ChangeLog qdbm-1.8.77.ebuild

[Donnie Berkholz]

On 17:16 Mon 04 Feb     , Akinori Hattori (hattya) wrote:
> 1.1                  dev-db/qdbm/qdbm-1.8.77.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-db/qdbm/qdbm-1.8.77.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-db/qdbm/qdbm-1.8.77.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 
> 	econf \
> 		$(use_enable debug) \
> 		$(use_enable zlib) \
> 		--enable-pthread \
> 		--enable-iconv \
> 		|| die
> 	emake || die
> 
> 	local u
> 
> 	for u in java perl ruby; do
> 		if ! use ${u}; then
> 			continue
> 		fi
> 
> 		cd ${u}
> 		econf || die
> 		emake || die
> 		cd -
> 	done
> 
> }

What happens if the make process changes directories? Does `cd -` still 
work as expected, or should you use pushd/popd instead?

Same point for src_test() and src_install().

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/qdbm: ChangeLog qdbm-1.8.77.ebuild

[Ciaran McCreesh]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

On Mon, 4 Feb 2008 23:05:18 -0800
Donnie Berkholz <dberkholz@gentoo.org> wrote:
> What happens if the make process changes directories?

In a different process? It's pretty unlikely make will ever become a
shell builtin...

-- 
Ciaran McCreesh

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-db/qdbm: ChangeLog qdbm-1.8.77.ebuild

[Donnie Berkholz]

On 07:13 Tue 05 Feb     , Ciaran McCreesh wrote:
> On Mon, 4 Feb 2008 23:05:18 -0800
> Donnie Berkholz <dberkholz@gentoo.org> wrote:
> > What happens if the make process changes directories?
> 
> In a different process? It's pretty unlikely make will ever become a
> shell builtin...

You're absolutely right.

I'm just overly wary of using things that are easy to break (say, if 
other code was added there).

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list