From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1JKam2-0007TB-HJ for garchives@archives.gentoo.org; Thu, 31 Jan 2008 14:52:18 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 23EB7E040F; Thu, 31 Jan 2008 14:52:17 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id F2F7BE040F for ; Thu, 31 Jan 2008 14:52:16 +0000 (UTC) Received: from trippin (unknown [88.239.27.172]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id BFB5365FA6 for ; Thu, 31 Jan 2008 14:52:15 +0000 (UTC) Date: Thu, 31 Jan 2008 16:51:58 +0200 From: Ali Polatel To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: gentoo-x86 commit in eclass: distutils.eclass Message-ID: <20080131145158.GA32199@trippin> Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20080124011341.GH4921@supernova> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+HP7ph2BbKc20aGI" Content-Disposition: inline In-Reply-To: <20080124011341.GH4921@supernova> User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: d060c69c-67eb-45b2-833d-b32254189f18 X-Archives-Hash: fe746c194b85d365d17916c34259fb86 --+HP7ph2BbKc20aGI Content-Type: text/plain; charset=iso-8859-9 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Donnie Berkholz yazm=FD=FE: > On 22:19 Wed 23 Jan , Ali Polatel (hawking) wrote: > > hawking 08/01/23 22:19:05 > >=20 > > Modified: distutils.eclass > > Log: > > Fixed ROOT usage for distutils_pkg_postinst failing when ROOT ends wi= th slash >=20 > > @@ -99,11 +99,14 @@ > > distutils_pkg_postinst() { > > PYTHON_MODNAME=3D${PYTHON_MODNAME:-${PN}} > > =20 > > + # strip trailing slash > > + myroot=3D"${ROOT%/}" > > + > > if has_version ">=3Ddev-lang/python-2.3"; then > > python_version > > for pymod in ${PYTHON_MODNAME}; do > > - if [ -d "${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/${py= mod}" ]; then > > - python_mod_optimize ${ROOT}usr/$(get_libdir)/python${PYVER}/site-p= ackages/${pymod} > > + if [ -d "${myroot}/usr/$(get_libdir)/python${PYVER}/site-packages/$= {pymod}" ]; then > > + python_mod_optimize ${myroot}/usr/$(get_libdir)/python${PYVER}/sit= e-packages/${pymod} > > fi > > done > > fi >=20 > Seems like this might be better fixed by properly handling ROOT in=20 > python.eclass instead of hacking around it. >=20 You're right. dev-zero has made some changes to these eclasses in python overlay[1] which I'll merge to the tree after some more testing. [1]: http://overlays.gentoo.org/proj/python/browser/overlays/testing/eclass -ali --+HP7ph2BbKc20aGI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) iD8DBQBHoeCOQU4yORhF8iARApu9AJ4jdA6dBDjI00NCqQKC+Yi6UZO4KgCeMOgc XTRxnZ8010sxdtW6wqG8030= =BDXM -----END PGP SIGNATURE----- --+HP7ph2BbKc20aGI-- -- gentoo-dev@lists.gentoo.org mailing list