From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1JHqf5-0004YK-63 for garchives@archives.gentoo.org; Thu, 24 Jan 2008 01:13:47 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4AD10E0459; Thu, 24 Jan 2008 01:13:45 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 2225AE0459 for ; Thu, 24 Jan 2008 01:13:45 +0000 (UTC) Received: from gentoo.org (c-67-171-150-177.hsd1.or.comcast.net [67.171.150.177]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 37D6965762; Thu, 24 Jan 2008 01:13:43 +0000 (UTC) Date: Wed, 23 Jan 2008 17:13:41 -0800 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org, hawking@gentoo.org Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: distutils.eclass Message-ID: <20080124011341.GH4921@supernova> References: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) X-Archives-Salt: 0b5ffbb0-f238-4cd4-8a5d-004a5548cf75 X-Archives-Hash: ee3fb252de1d57272a2ec0f3d11fe74f On 22:19 Wed 23 Jan , Ali Polatel (hawking) wrote: > hawking 08/01/23 22:19:05 > > Modified: distutils.eclass > Log: > Fixed ROOT usage for distutils_pkg_postinst failing when ROOT ends with slash > @@ -99,11 +99,14 @@ > distutils_pkg_postinst() { > PYTHON_MODNAME=${PYTHON_MODNAME:-${PN}} > > + # strip trailing slash > + myroot="${ROOT%/}" > + > if has_version ">=dev-lang/python-2.3"; then > python_version > for pymod in ${PYTHON_MODNAME}; do > - if [ -d "${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}" ]; then > - python_mod_optimize ${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/${pymod} > + if [ -d "${myroot}/usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}" ]; then > + python_mod_optimize ${myroot}/usr/$(get_libdir)/python${PYVER}/site-packages/${pymod} > fi > done > fi Seems like this might be better fixed by properly handling ROOT in python.eclass instead of hacking around it. Thanks, Donnie -- gentoo-dev@lists.gentoo.org mailing list