public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org, hawking@gentoo.org
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: distutils.eclass
Date: Wed, 23 Jan 2008 17:13:41 -0800	[thread overview]
Message-ID: <20080124011341.GH4921@supernova> (raw)
In-Reply-To: <E1JHnw1-0006f5-3X@stork.gentoo.org>

On 22:19 Wed 23 Jan     , Ali Polatel (hawking) wrote:
> hawking     08/01/23 22:19:05
> 
>   Modified:             distutils.eclass
>   Log:
>   Fixed ROOT usage for distutils_pkg_postinst failing when ROOT ends with slash

> @@ -99,11 +99,14 @@
>  distutils_pkg_postinst() {
>  	PYTHON_MODNAME=${PYTHON_MODNAME:-${PN}}
>  
> +	# strip trailing slash
> +	myroot="${ROOT%/}"
> +
>  	if has_version ">=dev-lang/python-2.3"; then
>  		python_version
>  		for pymod in ${PYTHON_MODNAME}; do
> -			if [ -d "${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}" ]; then
> -				python_mod_optimize ${ROOT}usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}
> +			if [ -d "${myroot}/usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}" ]; then
> +				python_mod_optimize ${myroot}/usr/$(get_libdir)/python${PYVER}/site-packages/${pymod}
>  			fi
>  		done
>  	fi

Seems like this might be better fixed by properly handling ROOT in 
python.eclass instead of hacking around it.

Thanks,
Donnie
-- 
gentoo-dev@lists.gentoo.org mailing list



       reply	other threads:[~2008-01-24  1:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1JHnw1-0006f5-3X@stork.gentoo.org>
2008-01-24  1:13 ` Donnie Berkholz [this message]
2008-01-31 14:51   ` [gentoo-dev] Re: gentoo-x86 commit in eclass: distutils.eclass Ali Polatel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080124011341.GH4921@supernova \
    --to=dberkholz@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=hawking@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox